Changeset 54088 for trunk/tests/phpunit/tests/oembed/controller.php

Timestamp:

09/06/2022 10:03:10 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Correctly use the factory method.

This replaces all non-static calls to the WP_UnitTestCase_Base::factory() method with static function calls, since the method is declared as static.

This is a consistency improvement for the test suite.

Follow up to [35225], [35242], [49603], [54087].

Props jrf.
See #55652.

File:

• trunk/tests/phpunit/tests/oembed/controller.php (modified) (6 diffs)

trunk/tests/phpunit/tests/oembed/controller.php

@@ -291 +291 @@
 
         public function test_request_invalid_format() {
-                $post_id = $this->factory()->post->create();
+                $post_id = self::factory()->post->create();
 
                 $request = new WP_REST_Request( 'GET', '/oembed/1.0/embed' );
@@ -462 +462 @@
 
         public function test_rest_pre_serve_request() {
-                $user = $this->factory()->user->create_and_get(
+                $user = self::factory()->user->create_and_get(
                         array(
                                 'display_name' => 'John Doe',
                         )
                 );
-                $post = $this->factory()->post->create_and_get(
+                $post = self::factory()->post->create_and_get(
                         array(
                                 'post_author' => $user->ID,
@@ -486 +486 @@
 
         public function test_rest_pre_serve_request_wrong_format() {
-                $post = $this->factory()->post->create_and_get();
+                $post = self::factory()->post->create_and_get();
 
                 $request = new WP_REST_Request( 'GET', '/oembed/1.0/embed' );
@@ -498 +498 @@
 
         public function test_rest_pre_serve_request_wrong_method() {
-                $post = $this->factory()->post->create_and_get();
+                $post = self::factory()->post->create_and_get();
 
                 $request = new WP_REST_Request( 'HEAD', '/oembed/1.0/embed' );
@@ -514 +514 @@
                 $this->assertSame( home_url() . '/index.php?rest_route=/oembed/1.0/embed', get_oembed_endpoint_url( '', 'xml' ) );
 
-                $post_id     = $this->factory()->post->create();
+                $post_id     = self::factory()->post->create();
                 $url         = get_permalink( $post_id );
                 $url_encoded = urlencode( $url );
@@ -528 +528 @@
                 $this->assertSame( home_url() . '/wp-json/oembed/1.0/embed', get_oembed_endpoint_url( '', 'xml' ) );
 
-                $post_id     = $this->factory()->post->create();
+                $post_id     = self::factory()->post->create();
                 $url         = get_permalink( $post_id );
                 $url_encoded = urlencode( $url );