Changeset 54090 for trunk/tests/phpunit/tests/general/template.php

Timestamp:

09/06/2022 10:09:49 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use the factory method instead of the property.

This replaces all references to the WP_UnitTestCase_Base::$factory property with static function calls to the WP_UnitTestCase_Base::factory() method.

This is a consistency improvement for the test suite.

Follow up to [35225], [35242], [49603], [54087], [54088].

Props jrf.
See #55652.

File:

• trunk/tests/phpunit/tests/general/template.php (modified) (8 diffs)

trunk/tests/phpunit/tests/general/template.php

@@ -105 +105 @@
      */
     public function test_has_site_icon_returns_true_when_called_for_other_site_with_site_icon_set() {
-        $blog_id = $this->factory->blog->create();
+        $blog_id = self::factory()->blog->create();
         switch_to_blog( $blog_id );
         $this->set_site_icon();
@@ -120 +120 @@
      */
     public function test_has_site_icon_returns_false_when_called_for_other_site_without_site_icon_set() {
-        $blog_id = $this->factory->blog->create();
+        $blog_id = self::factory()->blog->create();
 
         $this->assertFalse( has_site_icon( $blog_id ) );
@@ -299 +299 @@
      */
     public function test_has_custom_logo_returns_true_when_called_for_other_site_with_custom_logo_set() {
-        $blog_id = $this->factory->blog->create();
+        $blog_id = self::factory()->blog->create();
         switch_to_blog( $blog_id );
         $this->set_custom_logo();
@@ -314 +314 @@
      */
     public function test_has_custom_logo_returns_false_when_called_for_other_site_without_custom_logo_set() {
-        $blog_id = $this->factory->blog->create();
+        $blog_id = self::factory()->blog->create();
 
         $this->assertFalse( has_custom_logo( $blog_id ) );
@@ -344 +344 @@
      */
     public function test_get_custom_logo_returns_logo_when_called_for_other_site_with_custom_logo_set() {
-        $blog_id = $this->factory->blog->create();
+        $blog_id = self::factory()->blog->create();
         switch_to_blog( $blog_id );
 
@@ -467 +467 @@
      */
     public function test_get_site_icon_url_preserves_switched_state() {
-        $blog_id = $this->factory->blog->create();
+        $blog_id = self::factory()->blog->create();
         switch_to_blog( $blog_id );
 
@@ -487 +487 @@
      */
     public function test_has_custom_logo_preserves_switched_state() {
-        $blog_id = $this->factory->blog->create();
+        $blog_id = self::factory()->blog->create();
         switch_to_blog( $blog_id );
 
@@ -507 +507 @@
      */
     public function test_get_custom_logo_preserves_switched_state() {
-        $blog_id = $this->factory->blog->create();
+        $blog_id = self::factory()->blog->create();
         switch_to_blog( $blog_id );