Changeset 54108

Timestamp:

09/08/2022 11:39:17 PM (2 years ago)

Author:

desrosj

Message:

Build/Test Tools: Use the default GITHUB_TOKEN instead of a personal access token.

Previously, it was not possible to use the default GITHUB_TOKEN token to create new workflow runs in an effort to prevent accidental recursive workflows.

This has changed, and the workflow_dispatch is now one of two exceptions to this rule. Using GITHUB_TOKEN is preferred whenever possible to avoid the need for a PAT (personal access token), which expires (when created using the recommended security best practices), and is tied to an individual user.

See ​https://github.blog/changelog/2022-09-08-github-actions-use-github_token-with-workflow_dispatch-and-repository_dispatch/.

See #55652.

Location:

trunk/.github/workflows

Files:

• coding-standards.yml (modified) (1 diff)
• end-to-end-tests.yml (modified) (1 diff)
• javascript-tests.yml (modified) (1 diff)
• php-compatibility.yml (modified) (1 diff)
• phpunit-tests.yml (modified) (1 diff)
• test-coverage.yml (modified) (1 diff)
• test-npm.yml (modified) (1 diff)
• test-old-branches.yml (modified) (1 diff)

trunk/.github/workflows/coding-standards.yml

@@ -193 +193 @@
         uses: actions/github-script@c713e510dbd7d213d92d41b7a7805a986f4c5c66 # v6.2.0
         with:
-          github-token: ${{ secrets.GHA_WORKFLOW_DISPATCH }}
           script: |
             github.rest.actions.createWorkflowDispatch({

trunk/.github/workflows/end-to-end-tests.yml

@@ -149 +149 @@
         uses: actions/github-script@c713e510dbd7d213d92d41b7a7805a986f4c5c66 # v6.2.0
         with:
-          github-token: ${{ secrets.GHA_WORKFLOW_DISPATCH }}
           script: |
             github.rest.actions.createWorkflowDispatch({

trunk/.github/workflows/javascript-tests.yml

@@ -117 +117 @@
         uses: actions/github-script@c713e510dbd7d213d92d41b7a7805a986f4c5c66 # v6.2.0
         with:
-          github-token: ${{ secrets.GHA_WORKFLOW_DISPATCH }}
           script: |
             github.rest.actions.createWorkflowDispatch({

trunk/.github/workflows/php-compatibility.yml

@@ -133 +133 @@
         uses: actions/github-script@c713e510dbd7d213d92d41b7a7805a986f4c5c66 # v6.2.0
         with:
-          github-token: ${{ secrets.GHA_WORKFLOW_DISPATCH }}
           script: |
             github.rest.actions.createWorkflowDispatch({

trunk/.github/workflows/phpunit-tests.yml

@@ -264 +264 @@
         uses: actions/github-script@c713e510dbd7d213d92d41b7a7805a986f4c5c66 # v6.2.0
         with:
-          github-token: ${{ secrets.GHA_WORKFLOW_DISPATCH }}
           script: |
             github.rest.actions.createWorkflowDispatch({

trunk/.github/workflows/test-coverage.yml

@@ -212 +212 @@
         uses: actions/github-script@c713e510dbd7d213d92d41b7a7805a986f4c5c66 # v6.2.0
         with:
-          github-token: ${{ secrets.GHA_WORKFLOW_DISPATCH }}
           script: |
             github.rest.actions.createWorkflowDispatch({

trunk/.github/workflows/test-npm.yml

@@ -191 +191 @@
         uses: actions/github-script@c713e510dbd7d213d92d41b7a7805a986f4c5c66 # v6.2.0
         with:
-          github-token: ${{ secrets.GHA_WORKFLOW_DISPATCH }}
           script: |
             github.rest.actions.createWorkflowDispatch({

trunk/.github/workflows/test-old-branches.yml

@@ -71 +71 @@
         if: ${{ github.event_name == 'push' || github.event.schedule == '0 0 15 * *' || matrix.branch == '6.0' }}
         with:
-          github-token: ${{ secrets.GHA_WORKFLOW_DISPATCH }}
           script: |
             github.rest.actions.createWorkflowDispatch({