Changeset 54110 for trunk/src/wp-includes/cron.php

Timestamp:

09/09/2022 01:51:52 AM (2 years ago)

Author:

peterwilsoncc

Message:

Cron API: Remove unnecessary optimization getting ready events.

Remove the check for future events prior iterating the array of crons in wp_get_ready_cron_jobs(). If there are no ready events, the foreach loop will break on the first iteration so the optimization is not required.

As WordPress Core adds a number of events by default, accounting for an empty array is not required in most instances.

Props lev0, jrf, SergeyBiryukov.
Fixes #56092.

File:

• trunk/src/wp-includes/cron.php (modified) (2 diffs)

trunk/src/wp-includes/cron.php

@@ -1123 +1123 @@
      */
     $pre = apply_filters( 'pre_get_ready_cron_jobs', null );
+
     if ( null !== $pre ) {
         return $pre;
@@ -1128 +1129 @@
 
     $crons = _get_cron_array();
-
     $gmt_time = microtime( true );
-    $keys     = array_keys( $crons );
-    if ( isset( $keys[0] ) && $keys[0] > $gmt_time ) {
-        return array();
-    }
-
     $results = array();
+
     foreach ( $crons as $timestamp => $cronhooks ) {
         if ( $timestamp > $gmt_time ) {
             break;
         }
+
         $results[ $timestamp ] = $cronhooks;
     }