Changeset 54112 for trunk/src/wp-includes/class-wp-widget.php

Timestamp:

09/09/2022 02:17:33 AM (2 years ago)

Author:

peterwilsoncc

Message:

Widgets: Store default options for uninitialized widgets.

Prevent unnecessary database queries on page load by initializing widget options. On sites with uninitialized widgets, this prevents one or two database queries per uninitialized widget on each page load.

Props Chouby, mvraghavan, costdev, peterwilsoncc, spacedmonkey, mukesh27.
Fixes #54677.

File:

• trunk/src/wp-includes/class-wp-widget.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-widget.php

@@ -613 +613 @@
 
         if ( false === $settings ) {
+            $settings = array();
             if ( isset( $this->alt_option_name ) ) {
-                $settings = get_option( $this->alt_option_name );
-            } else {
-                // Save an option so it can be autoloaded next time.
-                $this->save_settings( array() );
-            }
+                // Get settings from alternative (legacy) option.
+                $settings = get_option( $this->alt_option_name, array() );
+
+                // Delete the alternative (legacy) option as the new option will be created using `$this->option_name`.
+                delete_option( $this->alt_option_name );
+            }
+            // Save an option so it can be autoloaded next time.
+            $this->save_settings( $settings );
         }