Changeset 54128

Timestamp:

09/11/2022 10:17:04 PM (2 years ago)

Author:

antpb

Message:

Media: Add muted property for video elements.

This change allows for the muted property to be used in video elements which solves for content that wishes to autoPlay when a page is viewed. Adding muted to video elements adhears to the requirements browsers have to honor autoPlay functionality.

Props prokium, peterwilsoncc, costdev, johnbillion, Benouare.
Fixes #54788.

Location:

trunk

Files:

• src/wp-includes/media.php (modified) (3 diffs)
• tests/phpunit/tests/media.php (modified) (4 diffs)

trunk/src/wp-includes/media.php

@@ -3220 +3220 @@
  *     @type string $loop     The 'loop' attribute for the `<video>` element. Default empty.
  *     @type string $autoplay The 'autoplay' attribute for the `<video>` element. Default empty.
+ *     @type string $muted    The 'muted' attribute for the `<video>` element. Default false.
  *     @type string $preload  The 'preload' attribute for the `<video>` element.
  *                            Default 'metadata'.
@@ -3264 +3265 @@
         'loop'     => '',
         'autoplay' => '',
+        'muted'    => 'false',
         'preload'  => 'metadata',
         'width'    => 640,
@@ -3391 +3393 @@
         'loop'     => wp_validate_boolean( $atts['loop'] ),
         'autoplay' => wp_validate_boolean( $atts['autoplay'] ),
+        'muted'    => wp_validate_boolean( $atts['muted'] ),
         'preload'  => $atts['preload'],
     );
 
     // These ones should just be omitted altogether if they are blank.
-    foreach ( array( 'poster', 'loop', 'autoplay', 'preload' ) as $a ) {
+    foreach ( array( 'poster', 'loop', 'autoplay', 'preload', 'muted' ) as $a ) {
         if ( empty( $html_atts[ $a ] ) ) {
             unset( $html_atts[ $a ] );

trunk/tests/phpunit/tests/media.php

@@ -1024 +1024 @@
     /**
      * @ticket 35367
+     * @ticket 54788
      * @depends test_video_shortcode_body
      */
@@ -1036 +1037 @@
         $this->assertStringNotContainsString( 'loop', $actual );
         $this->assertStringNotContainsString( 'autoplay', $actual );
+        $this->assertStringNotContainsString( 'muted', $actual );
         $this->assertStringContainsString( 'preload="metadata"', $actual );
         $this->assertStringContainsString( 'width="640"', $actual );
@@ -1047 +1049 @@
                 'loop'     => true,
                 'autoplay' => true,
+                'muted'    => true,
                 'preload'  => true,
                 'width'    => 123,
@@ -1058 +1061 @@
         $this->assertStringContainsString( 'loop="1"', $actual );
         $this->assertStringContainsString( 'autoplay="1"', $actual );
+        $this->assertStringContainsString( 'muted', $actual );
         $this->assertStringContainsString( 'preload="1"', $actual );
         $this->assertStringContainsString( 'width="123"', $actual );