Changeset 54134 for trunk/src/wp-includes/comment-template.php

Timestamp:

09/12/2022 05:50:36 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace deprecated string interpolation patterns.

PHP 8.2 deprecates string interpolation patterns that place the dollar sign outside the curly braces:

echo "Hello ${name}";

This commit fixes such patterns by replacing them with proper curly braced patterns:

echo "Hello {$name}";

This addresses Deprecated: Using ${var} in strings is deprecated, use {$var} instead notices when running tests on PHP 8.2.

References:

• ​PHP.Watch: PHP 8.2: ${var} string interpolation deprecated
• ​PHP RFC: Deprecate ${} string interpolation

Follow-up to [10584], [31733], [42360], [53922].

Props ayeshrajans, jrf.
Fixes #55787.

File:

• trunk/src/wp-includes/comment-template.php (modified) (1 diff)

trunk/src/wp-includes/comment-template.php

@@ -1739 +1739 @@
 
         foreach ( $data_attributes as $name => $value ) {
-            $data_attribute_string .= " data-${name}=\"" . esc_attr( $value ) . '"';
+            $data_attribute_string .= " data-{$name}=\"" . esc_attr( $value ) . '"';
         }