Changeset 54147

Timestamp:

09/13/2022 08:19:17 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Tests: Rename the test for pre_option filter to match the filter name.

Move the method to a more appropriate place, next to the test for default_option_* filter.

Follow-up to [54145].

See #37930.

File:

• trunk/tests/phpunit/tests/option/option.php (modified) (3 diffs)

trunk/tests/phpunit/tests/option/option.php

@@ -46 +46 @@
      * @covers ::delete_option
      */
-    public function test_default_filter() {
+    public function test_default_option_filter() {
         $value = 'value';
 
@@ -84 +84 @@
         $this->assertTrue( $added );
         $this->assertSame( 'bar', get_option( 'doesnotexist' ) );
+    }
+
+    /**
+     * @ticket 37930
+     *
+     * @covers ::get_option
+     */
+    public function test_get_option_should_call_pre_option_filter() {
+        $filter = new MockAction();
+
+        add_filter( 'pre_option', array( $filter, 'filter' ) );
+
+        get_option( 'ignored' );
+
+        $this->assertSame( 1, $filter->get_call_count() );
     }
 
@@ -298 +313 @@
         );
     }
-
-    /**
-     * @ticket 37930
-     *
-     * @covers ::get_option
-     */
-    public function test_filter_pre_option_all_filter_is_called() {
-        $filter = new MockAction();
-
-        add_filter( 'pre_option', array( $filter, 'filter' ) );
-
-        get_option( 'ignored' );
-
-        $this->assertSame( 1, $filter->get_call_count() );
-    }
 }