Changeset 54155 for trunk/tests/phpunit/tests/rest-api/rest-block-type-controller.php

Timestamp:

09/14/2022 10:50:26 AM (2 years ago)

Author:

gziolo

Message:

Blocks: Allow registering multiple items for all supported asset types

Follow-up #54337, [52069]. Part of ​https://github.com/WordPress/gutenberg/issues/41236. More details in ​https://github.com/WordPress/gutenberg/issues/33542.

Allow passing more than one script per block for editorScript, script, and viewScript fields in the block.json metadata file. This aligns with the previously added changes for style and editorStyle fields.

This change impacts the WP_Block_Type class and the REST API endpoint for block types. To ensure backward compatibiliy old names were soft deprecated in favor of new fields that work with array values and have _handles suffix.

Props zieladam, dlh, timothyblynjacobs, aristath, bernhard-reiter.
Fixes #56408.

File:

• trunk/tests/phpunit/tests/rest-api/rest-block-type-controller.php (modified) (9 diffs)

trunk/tests/phpunit/tests/rest-api/rest-block-type-controller.php

@@ -238 +238 @@
         $this->assertSame( '1', $data['description'] );
         $this->assertNull( $data['icon'] );
-        $this->assertNull( $data['editor_script'] );
-        $this->assertNull( $data['script'] );
-        $this->assertNull( $data['view_script'] );
-        $this->assertNull( $data['editor_style'] );
-        $this->assertNull( $data['style'] );
+        $this->assertSameSets( array(), $data['editor_script_handles'] );
+        $this->assertSameSets( array(), $data['script_handles'] );
+        $this->assertSameSets( array(), $data['view_script_handles'] );
+        $this->assertSameSets( array(), $data['editor_style_handles'] );
+        $this->assertSameSets( array(), $data['style_handles'] );
         $this->assertSameSets( array(), $data['provides_context'] );
         $this->assertSameSetsWithIndex(
@@ -261 +261 @@
         $this->assertFalse( $data['is_dynamic'] );
         $this->assertSameSets( array( array() ), $data['variations'] );
+        // Deprecated properties.
+        $this->assertNull( $data['editor_script'] );
+        $this->assertNull( $data['script'] );
+        $this->assertNull( $data['view_script'] );
+        $this->assertNull( $data['editor_style'] );
+        $this->assertNull( $data['style'] );
+
     }
 
@@ -300 +307 @@
         $this->assertSame( '', $data['description'] );
         $this->assertNull( $data['icon'] );
-        $this->assertNull( $data['editor_script'] );
-        $this->assertNull( $data['script'] );
-        $this->assertNull( $data['view_script'] );
-        $this->assertNull( $data['editor_style'] );
-        $this->assertNull( $data['style'] );
+        $this->assertSameSets( array(), $data['editor_script_handles'] );
+        $this->assertSameSets( array(), $data['script_handles'] );
+        $this->assertSameSets( array(), $data['view_script_handles'] );
+        $this->assertSameSets( array(), $data['editor_style_handles'] );
+        $this->assertSameSets( array(), $data['style_handles'] );
         $this->assertSameSetsWithIndex(
             array(
@@ -324 +331 @@
         $this->assertFalse( $data['is_dynamic'] );
         $this->assertSameSets( array(), $data['variations'] );
+        // Deprecated properties.
+        $this->assertNull( $data['editor_script'] );
+        $this->assertNull( $data['script'] );
+        $this->assertNull( $data['view_script'] );
+        $this->assertNull( $data['editor_style'] );
+        $this->assertNull( $data['style'] );
     }
 
@@ -393 +406 @@
         $data       = $response->get_data();
         $properties = $data['schema']['properties'];
-        $this->assertCount( 23, $properties );
+        $this->assertCount( 28, $properties );
         $this->assertArrayHasKey( 'api_version', $properties );
         $this->assertArrayHasKey( 'title', $properties );
@@ -406 +419 @@
         $this->assertArrayHasKey( 'category', $properties );
         $this->assertArrayHasKey( 'is_dynamic', $properties );
-        $this->assertArrayHasKey( 'editor_script', $properties );
-        $this->assertArrayHasKey( 'script', $properties );
-        $this->assertArrayHasKey( 'view_script', $properties );
-        $this->assertArrayHasKey( 'editor_style', $properties );
-        $this->assertArrayHasKey( 'style', $properties );
+        $this->assertArrayHasKey( 'editor_script_handles', $properties );
+        $this->assertArrayHasKey( 'script_handles', $properties );
+        $this->assertArrayHasKey( 'view_script_handles', $properties );
+        $this->assertArrayHasKey( 'editor_style_handles', $properties );
+        $this->assertArrayHasKey( 'style_handles', $properties );
         $this->assertArrayHasKey( 'parent', $properties );
         $this->assertArrayHasKey( 'example', $properties );
@@ -417 +430 @@
         $this->assertArrayHasKey( 'variations', $properties );
         $this->assertArrayHasKey( 'ancestor', $properties );
+        // Deprecated properties.
+        $this->assertArrayHasKey( 'editor_script', $properties );
+        $this->assertArrayHasKey( 'script', $properties );
+        $this->assertArrayHasKey( 'view_script', $properties );
+        $this->assertArrayHasKey( 'editor_style', $properties );
+        $this->assertArrayHasKey( 'style', $properties );
+
     }
 
@@ -519 +539 @@
             'name',
             'category',
-            'editor_script',
-            'script',
-            'view_script',
-            'editor_style',
-            'style',
+            'editor_script_handles',
+            'script_handles',
+            'view_script_handles',
+            'editor_style_handles',
+            'style_handles',
             'title',
             'icon',
@@ -535 +555 @@
             'textdomain',
             'example',
+            // Deprecated fields.
+            'editor_script',
+            'script',
+            'view_script',
+            'editor_style',
+            'style',
         );