Changeset 54177

Timestamp:

09/15/2022 12:27:02 PM (2 years ago)

Author:

audrasjb

Message:

Help/About: Remove .hidden class when the Help Tab panel is displayed.

It is obviously more logical and semantic to remove the hidden class when the panel is displayed. Plus, it prevents from weird behavior occurring when plugins also use the hidden class to hide stuff.

Props grabmedia, SergeyBiryukov, helen, sabernhardt, costdev, audrasjb.
Fixes #27697.

File:

• trunk/src/js/_enqueues/admin/common.js (modified) (2 diffs)

trunk/src/js/_enqueues/admin/common.js

@@ -618 +618 @@
          */
         panel.slideDown( 'fast', function() {
-            panel.trigger( 'focus' );
+            panel.removeClass( 'hidden' ).trigger( 'focus' );
             button.addClass( 'screen-meta-active' ).attr( 'aria-expanded', true );
         });
@@ -647 +647 @@
             $('.screen-meta-toggle').css('visibility', '');
             panel.parent().hide();
+            panel.addClass( 'hidden' );
         });