Changeset 54207 for trunk/tests/phpunit/tests/date/query.php

Timestamp:

09/19/2022 05:43:55 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Reset timezone-related options if the tests change them.

The options table is not explicitly reset after each test or test class, so if an option is changed during a test, it should be reset to the default value after the test.

This commit does so for those tests which did not have such resetting in place yet, while one or more tests in the class do change the value of the timezone_string option.

Note: The test suite executes a ROLLBACK query after each test, which should reset the options table in theory, however that appears to not always be enough, as some timezone-related tests can fail in a complete test suite run, while not failing when run in isolation. This commit aims to improve stability of the tests.

Follow-up to [45857] / #45821.

Props jrf, costdev.
See #56468.

File:

• trunk/tests/phpunit/tests/date/query.php (modified) (1 diff)

trunk/tests/phpunit/tests/date/query.php

@@ -20 +20 @@
         unset( $this->q );
         $this->q = new WP_Date_Query( array( 'm' => 2 ) );
+    }
+
+    /**
+     * Cleans up.
+     */
+    public function tear_down() {
+        // Reset the timezone option to the default value.
+        update_option( 'timezone_string', '' );
+
+        parent::tear_down();
     }