Changeset 54215 for trunk/src/wp-admin/includes/class-wp-comments-list-table.php

Timestamp:

09/19/2022 09:06:08 PM (2 years ago)

Author:

davidbaumwald

Message:

Administration: Add new get_views_links method to WP_List_Table.

Many WP_List_Table child classes in core use mostly the same code to create their "view" links markup. To DRY-up the code, a new WP_List_Table->get_view_links method is being introduced to consolidate the HTML link generation when provided an array of links.

This change also implements this new method in the relevant WP_List_Table_xxx child classes get_views methods. Finally, unit tests are being added to validate view links markup and test for some "unhappy paths".

Props afercia, costdev, garrett-eclipse, Dharm1025, juhise, peterwilsoncc.
Fixes #42066.

File:

• trunk/src/wp-admin/includes/class-wp-comments-list-table.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-comments-list-table.php

@@ -294 +294 @@
 
         foreach ( $stati as $status => $label ) {
-            $current_link_attributes = '';
-
-            if ( $status === $comment_status ) {
-                $current_link_attributes = ' class="current" aria-current="page"';
-            }
-
             if ( 'mine' === $status ) {
                 $current_user_id    = get_current_user_id();
@@ -330 +324 @@
             */
 
-            $status_links[ $status ] = "<a href='$link'$current_link_attributes>" . sprintf(
-                translate_nooped_plural( $label, $num_comments->$status ),
-                sprintf(
-                    '<span class="%s-count">%s</span>',
-                    ( 'moderated' === $status ) ? 'pending' : $status,
-                    number_format_i18n( $num_comments->$status )
-                )
-            ) . '</a>';
+            $status_links[ $status ] = array(
+                'url'     => esc_url( $link ),
+                'label'   => sprintf(
+                    translate_nooped_plural( $label, $num_comments->$status ),
+                    sprintf(
+                        '<span class="%s-count">%s</span>',
+                        ( 'moderated' === $status ) ? 'pending' : $status,
+                        number_format_i18n( $num_comments->$status )
+                    )
+                ),
+                'current' => $status === $comment_status,
+            );
         }
 
@@ -349 +347 @@
          *                              'Pending', 'Approved', 'Spam', and 'Trash'.
          */
-        return apply_filters( 'comment_status_links', $status_links );
+        return apply_filters( 'comment_status_links', $this->get_views_links( $status_links ) );
     }