Changeset 54215 for trunk/src/wp-admin/includes/class-wp-ms-sites-list-table.php

Timestamp:

09/19/2022 09:06:08 PM (2 years ago)

Author:

davidbaumwald

Message:

Administration: Add new get_views_links method to WP_List_Table.

Many WP_List_Table child classes in core use mostly the same code to create their "view" links markup. To DRY-up the code, a new WP_List_Table->get_view_links method is being introduced to consolidate the HTML link generation when provided an array of links.

This change also implements this new method in the relevant WP_List_Table_xxx child classes get_views methods. Finally, unit tests are being added to validate view links markup and test for some "unhappy paths".

Props afercia, costdev, garrett-eclipse, Dharm1025, juhise, peterwilsoncc.
Fixes #42066.

File:

• trunk/src/wp-admin/includes/class-wp-ms-sites-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-ms-sites-list-table.php

@@ -263 +263 @@
 
         foreach ( $statuses as $status => $label_count ) {
-            $current_link_attributes = $requested_status === $status || ( '' === $requested_status && 'all' === $status )
-                ? ' class="current" aria-current="page"'
-                : '';
             if ( (int) $counts[ $status ] > 0 ) {
                 $label    = sprintf( translate_nooped_plural( $label_count, $counts[ $status ] ), number_format_i18n( $counts[ $status ] ) );
                 $full_url = 'all' === $status ? $url : add_query_arg( 'status', $status, $url );
 
-                $view_links[ $status ] = sprintf(
-                    '<a href="%1$s"%2$s>%3$s</a>',
-                    esc_url( $full_url ),
-                    $current_link_attributes,
-                    $label
+                $view_links[ $status ] = array(
+                    'url'     => esc_url( $full_url ),
+                    'label'   => $label,
+                    'current' => $requested_status === $status || ( '' === $requested_status && 'all' === $status ),
                 );
             }
         }
 
-        return $view_links;
+        return $this->get_views_links( $view_links );
     }