Changeset 54215 for trunk/src/wp-admin/includes/class-wp-ms-users-list-table.php

Timestamp:

09/19/2022 09:06:08 PM (2 years ago)

Author:

davidbaumwald

Message:

Administration: Add new get_views_links method to WP_List_Table.

Many WP_List_Table child classes in core use mostly the same code to create their "view" links markup. To DRY-up the code, a new WP_List_Table->get_view_links method is being introduced to consolidate the HTML link generation when provided an array of links.

This change also implements this new method in the relevant WP_List_Table_xxx child classes get_views methods. Finally, unit tests are being added to validate view links markup and test for some "unhappy paths".

Props afercia, costdev, garrett-eclipse, Dharm1025, juhise, peterwilsoncc.
Fixes #42066.

File:

• trunk/src/wp-admin/includes/class-wp-ms-users-list-table.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-ms-users-list-table.php

@@ -138 +138 @@
         $total_admins = count( $super_admins );
 
-        $current_link_attributes = 'super' !== $role ? ' class="current" aria-current="page"' : '';
-        $role_links              = array();
-        $role_links['all']       = sprintf(
-            '<a href="%s"%s>%s</a>',
-            network_admin_url( 'users.php' ),
-            $current_link_attributes,
-            sprintf(
+        $role_links        = array();
+        $role_links['all'] = array(
+            'url'     => network_admin_url( 'users.php' ),
+            'label'   => sprintf(
                 /* translators: Number of users. */
                 _nx(
@@ -153 +150 @@
                 ),
                 number_format_i18n( $total_users )
-            )
-        );
-        $current_link_attributes = 'super' === $role ? ' class="current" aria-current="page"' : '';
-        $role_links['super']     = sprintf(
-            '<a href="%s"%s>%s</a>',
-            network_admin_url( 'users.php?role=super' ),
-            $current_link_attributes,
-            sprintf(
+            ),
+            'current' => 'super' !== $role,
+        );
+
+        $role_links['super'] = array(
+            'url'     => network_admin_url( 'users.php?role=super' ),
+            'label'   => sprintf(
                 /* translators: Number of users. */
                 _n(
@@ -168 +164 @@
                 ),
                 number_format_i18n( $total_admins )
-            )
-        );
-
-        return $role_links;
+            ),
+            'current' => 'super' === $role,
+        );
+
+        return $this->get_views_links( $role_links );
     }