Changeset 54215 for trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php

Timestamp:

09/19/2022 09:06:08 PM (2 years ago)

Author:

davidbaumwald

Message:

Administration: Add new get_views_links method to WP_List_Table.

Many WP_List_Table child classes in core use mostly the same code to create their "view" links markup. To DRY-up the code, a new WP_List_Table->get_view_links method is being introduced to consolidate the HTML link generation when provided an array of links.

This change also implements this new method in the relevant WP_List_Table_xxx child classes get_views methods. Finally, unit tests are being added to validate view links markup and test for some "unhappy paths".

Props afercia, costdev, garrett-eclipse, Dharm1025, juhise, peterwilsoncc.
Fixes #42066.

File:

• trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php

@@ -311 +311 @@
         $display_tabs = array();
         foreach ( (array) $tabs as $action => $text ) {
-            $current_link_attributes                     = ( $action === $tab ) ? ' class="current" aria-current="page"' : '';
-            $href                                        = self_admin_url( 'plugin-install.php?tab=' . $action );
-            $display_tabs[ 'plugin-install-' . $action ] = "<a href='$href'$current_link_attributes>$text</a>";
+            $display_tabs[ 'plugin-install-' . $action ] = array(
+                'url'     => self_admin_url( 'plugin-install.php?tab=' . $action ),
+                'label'   => $text,
+                'current' => $action === $tab,
+            );
         }
         // No longer a real tab.
         unset( $display_tabs['plugin-install-upload'] );
 
-        return $display_tabs;
+        return $this->get_views_links( $display_tabs );
     }