Changeset 54215 for trunk/src/wp-admin/includes/class-wp-posts-list-table.php

Timestamp:

09/19/2022 09:06:08 PM (2 years ago)

Author:

davidbaumwald

Message:

Administration: Add new get_views_links method to WP_List_Table.

Many WP_List_Table child classes in core use mostly the same code to create their "view" links markup. To DRY-up the code, a new WP_List_Table->get_view_links method is being introduced to consolidate the HTML link generation when provided an array of links.

This change also implements this new method in the relevant WP_List_Table_xxx child classes get_views methods. Finally, unit tests are being added to validate view links markup and test for some "unhappy paths".

Props afercia, costdev, garrett-eclipse, Dharm1025, juhise, peterwilsoncc.
Fixes #42066.

File:

• trunk/src/wp-admin/includes/class-wp-posts-list-table.php (modified) (5 diffs)

trunk/src/wp-admin/includes/class-wp-posts-list-table.php

@@ -332 +332 @@
             );
 
-            $mine = $this->get_edit_link( $mine_args, $mine_inner_html, $class );
+            $mine = array(
+                'url'     => esc_url( add_query_arg( $mine_args, 'edit.php' ) ),
+                'label'   => $mine_inner_html,
+                'current' => isset( $_GET['author'] ) && ( $current_user_id === (int) $_GET['author'] ),
+            );
 
             $all_args['all_posts'] = 1;
             $class                 = '';
-        }
-
-        if ( empty( $class ) && ( $this->is_base_request() || isset( $_REQUEST['all_posts'] ) ) ) {
-            $class = 'current';
         }
 
@@ -353 +353 @@
         );
 
-        $status_links['all'] = $this->get_edit_link( $all_args, $all_inner_html, $class );
+        $status_links['all'] = array(
+            'url'     => esc_url( add_query_arg( $all_args, 'edit.php' ) ),
+            'label'   => $all_inner_html,
+            'current' => empty( $class ) && ( $this->is_base_request() || isset( $_REQUEST['all_posts'] ) ),
+        );
 
         if ( $mine ) {
@@ -382 +386 @@
             );
 
-            $status_links[ $status_name ] = $this->get_edit_link( $status_args, $status_label, $class );
+            $status_links[ $status_name ] = array(
+                'url'     => esc_url( add_query_arg( $status_args, 'edit.php' ) ),
+                'label'   => $status_label,
+                'current' => isset( $_REQUEST['post_status'] ) && $status_name === $_REQUEST['post_status'],
+            );
         }
 
@@ -405 +413 @@
 
             $sticky_link = array(
-                'sticky' => $this->get_edit_link( $sticky_args, $sticky_inner_html, $class ),
+                'sticky' => array(
+                    'url'     => esc_url( add_query_arg( $sticky_args, 'edit.php' ) ),
+                    'label'   => $sticky_inner_html,
+                    'current' => ! empty( $_REQUEST['show_sticky'] ),
+                ),
             );
 
@@ -413 +425 @@
         }
 
-        return $status_links;
+        return $this->get_views_links( $status_links );
     }