Changeset 54215 for trunk/src/wp-admin/includes/class-wp-privacy-requests-table.php

Timestamp:

09/19/2022 09:06:08 PM (3 years ago)

Author:

davidbaumwald

Message:

Administration: Add new get_views_links method to WP_List_Table.

Many WP_List_Table child classes in core use mostly the same code to create their "view" links markup. To DRY-up the code, a new WP_List_Table->get_view_links method is being introduced to consolidate the HTML link generation when provided an array of links.

This change also implements this new method in the relevant WP_List_Table_xxx child classes get_views methods. Finally, unit tests are being added to validate view links markup and test for some "unhappy paths".

Props afercia, costdev, garrett-eclipse, Dharm1025, juhise, peterwilsoncc.
Fixes #42066.

File:

• trunk/src/wp-admin/includes/class-wp-privacy-requests-table.php (modified) (4 diffs)

trunk/src/wp-admin/includes/class-wp-privacy-requests-table.php

@@ -154 +154 @@
         $admin_url = $this->get_admin_url();
 
-        $current_link_attributes = empty( $current_status ) ? ' class="current" aria-current="page"' : '';
-        $status_label            = sprintf(
+        $status_label = sprintf(
             /* translators: %s: Number of requests. */
             _nx(
@@ -166 +165 @@
         );
 
-        $views['all'] = sprintf(
-            '<a href="%s"%s>%s</a>',
-            esc_url( $admin_url ),
-            $current_link_attributes,
-            $status_label
+        $views['all'] = array(
+            'url'     => esc_url( $admin_url ),
+            'label'   => $status_label,
+            'current' => empty( $current_status ),
         );
 
@@ -179 +177 @@
             }
 
-            $current_link_attributes = $status === $current_status ? ' class="current" aria-current="page"' : '';
-            $total_status_requests   = absint( $counts->{$status} );
+            $total_status_requests = absint( $counts->{$status} );
 
             if ( ! $total_status_requests ) {
@@ -193 +190 @@
             $status_link = add_query_arg( 'filter-status', $status, $admin_url );
 
-            $views[ $status ] = sprintf(
-                '<a href="%s"%s>%s</a>',
-                esc_url( $status_link ),
-                $current_link_attributes,
-                $status_label
+            $views[ $status ] = array(
+                'url'     => esc_url( $status_link ),
+                'label'   => $status_label,
+                'current' => $status === $current_status,
             );
         }
 
-        return $views;
+        return $this->get_views_links( $views );
     }