Make WordPress Core

Changeset 54217 for trunk


Ignore:
Timestamp:
09/19/2022 09:18:59 PM (18 months ago)
Author:
SergeyBiryukov
Message:

Tests: Replace the timezone used in date/time tests.

The Europe/Kiev timezone has been deprecated in PHP 8.2 and replaced with Europe/Kyiv.

The tests updated in this commit are testing the WordPress date/time functionality. They are not testing whether WP or PHP can handle deprecated timezone names correctly.

To ensure the tests follow the original purpose, the use of Europe/Kiev within these tests is now replaced with the Europe/Helsinki timezone, which is within the same timezone as Europe/Kyiv. This should ensure that these tests run without issue and test what they are supposed to be testing on every supported PHP version (unless at some point in the future Europe/Helsinki would be renamed, but that's a bridge to cross if and when).

Note: Separate tests should/will be added to ensure that relevant date/time related functions handle a deprecated timezone correctly, but that is not something these tests are supposed to be testing.

Follow-up to [45853], [45856], [45876], [45882], [45887], [45908], [45914], [46577], [46154], [46580], [46864], [46974], [54207].

Props jrf, costdev.
See #56468.

Location:
trunk/tests/phpunit/tests
Files:
9 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/date/currentTime.php

    r54207 r54217  
    9393     */
    9494    public function test_should_return_wp_timestamp() {
    95         update_option( 'timezone_string', 'Europe/Kiev' );
     95        update_option( 'timezone_string', 'Europe/Helsinki' );
    9696
    9797        $timestamp = time();
     
    118118     */
    119119    public function test_should_return_correct_local_time() {
    120         update_option( 'timezone_string', 'Europe/Kiev' );
     120        update_option( 'timezone_string', 'Europe/Helsinki' );
    121121
    122122        $timestamp      = time();
  • trunk/tests/phpunit/tests/date/dateI18n.php

    r54207 r54217  
    2323     */
    2424    public function test_should_return_current_time_on_invalid_timestamp() {
    25         $timezone = 'Europe/Kiev';
     25        $timezone = 'Europe/Helsinki';
    2626        update_option( 'timezone_string', $timezone );
    2727
     
    3636     */
    3737    public function test_should_handle_zero_timestamp() {
    38         $timezone = 'Europe/Kiev';
     38        $timezone = 'Europe/Helsinki';
    3939        update_option( 'timezone_string', $timezone );
    4040
     
    155155     */
    156156    public function test_should_return_wp_timestamp() {
    157         update_option( 'timezone_string', 'Europe/Kiev' );
     157        update_option( 'timezone_string', 'Europe/Helsinki' );
    158158
    159159        $datetime     = new DateTimeImmutable( 'now', wp_timezone() );
     
    205205    public function dst_times() {
    206206        return array(
    207             'Before DST start' => array( '2019-03-31 02:59:00', 'Europe/Kiev' ),
    208             'After DST start'  => array( '2019-03-31 04:01:00', 'Europe/Kiev' ),
    209             'Before DST end'   => array( '2019-10-27 02:59:00', 'Europe/Kiev' ),
    210             'After DST end'    => array( '2019-10-27 04:01:00', 'Europe/Kiev' ),
     207            'Before DST start' => array( '2019-03-31 02:59:00', 'Europe/Helsinki' ),
     208            'After DST start'  => array( '2019-03-31 04:01:00', 'Europe/Helsinki' ),
     209            'Before DST end'   => array( '2019-10-27 02:59:00', 'Europe/Helsinki' ),
     210            'After DST end'    => array( '2019-10-27 04:01:00', 'Europe/Helsinki' ),
    211211        );
    212212    }
  • trunk/tests/phpunit/tests/date/getFeedBuildDate.php

    r54207 r54217  
    4848        global $wp_query;
    4949
    50         update_option( 'timezone_string', 'Europe/Kiev' );
     50        update_option( 'timezone_string', 'Europe/Helsinki' );
    5151        $datetime     = new DateTimeImmutable( 'now', wp_timezone() );
    5252        $datetime_utc = $datetime->setTimezone( new DateTimeZone( 'UTC' ) );
  • trunk/tests/phpunit/tests/date/getPostTime.php

    r54207 r54217  
    6262     */
    6363    public function test_should_return_wp_timestamp() {
    64         $timezone = 'Europe/Kiev';
     64        $timezone = 'Europe/Helsinki';
    6565        update_option( 'timezone_string', $timezone );
    6666
     
    9191     */
    9292    public function test_should_return_time() {
    93         $timezone = 'Europe/Kiev';
     93        $timezone = 'Europe/Helsinki';
    9494        update_option( 'timezone_string', $timezone );
    9595
     
    132132        );
    133133
    134         update_option( 'timezone_string', 'Europe/Kiev' );
     134        update_option( 'timezone_string', 'Europe/Helsinki' );
    135135
    136136        $this->assertSame( $rfc3339, get_post_time( DATE_RFC3339, true, $post_id ) );
  • trunk/tests/phpunit/tests/date/mysql2date.php

    r54207 r54217  
    3737     */
    3838    public function test_mysql2date_should_format_time() {
    39         $timezone = 'Europe/Kiev';
     39        $timezone = 'Europe/Helsinki';
    4040        update_option( 'timezone_string', $timezone );
    4141        $datetime = new DateTime( 'now', new DateTimeZone( $timezone ) );
     
    5151     */
    5252    public function test_mysql2date_should_format_time_with_changed_time_zone() {
    53         $timezone = 'Europe/Kiev';
     53        $timezone = 'Europe/Helsinki';
    5454        // phpcs:ignore WordPress.DateTime.RestrictedFunctions.timezone_change_date_default_timezone_set
    5555        date_default_timezone_set( $timezone );
     
    6767     */
    6868    public function test_mysql2date_should_return_wp_timestamp() {
    69         $timezone = 'Europe/Kiev';
     69        $timezone = 'Europe/Helsinki';
    7070        update_option( 'timezone_string', $timezone );
    7171        $datetime     = new DateTime( 'now', new DateTimeZone( $timezone ) );
     
    8181     */
    8282    public function test_mysql2date_should_return_unix_timestamp_for_gmt_time() {
    83         $timezone = 'Europe/Kiev';
     83        $timezone = 'Europe/Helsinki';
    8484        update_option( 'timezone_string', $timezone );
    8585        $datetime  = new DateTime( 'now', new DateTimeZone( 'UTC' ) );
  • trunk/tests/phpunit/tests/date/query.php

    r54207 r54217  
    572572     */
    573573    public function test_build_mysql_datetime_with_custom_timezone( $datetime, $expected, $default_to_max = false ) {
    574         update_option( 'timezone_string', 'Europe/Kiev' );
     574        update_option( 'timezone_string', 'Europe/Helsinki' );
    575575
    576576        $q = new WP_Date_Query( array() );
     
    594594     */
    595595    public function test_build_mysql_datetime_with_relative_date() {
    596         update_option( 'timezone_string', 'Europe/Kiev' );
     596        update_option( 'timezone_string', 'Europe/Helsinki' );
    597597
    598598        $q = new WP_Date_Query( array() );
  • trunk/tests/phpunit/tests/date/wpTimezone.php

    r54207 r54217  
    4343     */
    4444    public function test_should_return_timezone_string() {
    45         update_option( 'timezone_string', 'Europe/Kiev' );
     45        update_option( 'timezone_string', 'Europe/Helsinki' );
    4646
    47         $this->assertSame( 'Europe/Kiev', wp_timezone_string() );
     47        $this->assertSame( 'Europe/Helsinki', wp_timezone_string() );
    4848
    4949        $timezone = wp_timezone();
    5050
    51         $this->assertSame( 'Europe/Kiev', $timezone->getName() );
     51        $this->assertSame( 'Europe/Helsinki', $timezone->getName() );
    5252    }
    5353
  • trunk/tests/phpunit/tests/date/xmlrpc.php

    r54207 r54217  
    3535        }
    3636
    37         $timezone = 'Europe/Kiev';
     37        $timezone = 'Europe/Helsinki';
    3838        update_option( 'timezone_string', $timezone );
    3939
     
    155155     */
    156156    public function test_date_edit_post() {
    157         $timezone = 'Europe/Kiev';
     157        $timezone = 'Europe/Helsinki';
    158158        update_option( 'timezone_string', $timezone );
    159159
     
    224224     */
    225225    public function test_date_edit_comment() {
    226         $timezone = 'Europe/Kiev';
     226        $timezone = 'Europe/Helsinki';
    227227        update_option( 'timezone_string', $timezone );
    228228
  • trunk/tests/phpunit/tests/formatting/date.php

    r54207 r54217  
    234234        return array(
    235235            array(
    236                 'timezone_string' => 'Europe/Kiev',
     236                'timezone_string' => 'Europe/Helsinki',
    237237                'gmt_offset'      => 3,
    238238            ),
Note: See TracChangeset for help on using the changeset viewer.