Changeset 54234

Timestamp:

09/20/2022 01:13:51 AM (4 years ago)

Author:

peterwilsoncc

Message:

Posts, Post types: Cache get_page_by_title().

Convert get_page_by_title() to a WP_Query wrapper to take advantage of the object caching built in to the latter.

Add dedicated unit tests for the function get_page_by_title().

Props spacedmonkey, boonebgorges, igmoweb, pcfreak30, pbearne.
Fixes #36905.

Location:

trunk

Files:

• src/wp-includes/post.php (modified) (2 diffs)
• tests/phpunit/tests/post/getPageByTitle.php (added)

trunk/src/wp-includes/post.php

@@ -5757 +5757 @@
  * @since 3.0.0 The `$post_type` parameter was added.
  *
- * @global wpdb $wpdb WordPress database abstraction object.
- *
  * @param string       $page_title Page title.
  * @param string       $output     Optional. The required return type. One of OBJECT, ARRAY_A, or ARRAY_N, which
@@ -5767 +5765 @@
  */
 function get_page_by_title( $page_title, $output = OBJECT, $post_type = 'page' ) {
-        global $wpdb;
-
-        if ( is_array( $post_type ) ) {
-                $post_type           = esc_sql( $post_type );
-                $post_type_in_string = "'" . implode( "','", $post_type ) . "'";
-                $sql                 = $wpdb->prepare(
-                        "
-                        SELECT ID
-                        FROM $wpdb->posts
-                        WHERE post_title = %s
-                        AND post_type IN ($post_type_in_string)
-                ",
-                        $page_title
-                );
-        } else {
-                $sql = $wpdb->prepare(
-                        "
-                        SELECT ID
-                        FROM $wpdb->posts
-                        WHERE post_title = %s
-                        AND post_type = %s
-                ",
-                        $page_title,
-                        $post_type
-                );
-        }
-
-        $page = $wpdb->get_var( $sql );
-
-        if ( $page ) {
-                return get_post( $page, $output );
-        }
-
-        return null;
+        $args  = array(
+                'post_title'             => $page_title,
+                'post_type'              => $post_type,
+                'post_status'            => get_post_stati(),
+                'posts_per_page'         => 1,
+                'update_post_term_cache' => false,
+                'update_post_meta_cache' => false,
+                'no_found_rows'          => true,
+                'orderby'                => 'ID',
+                'order'                  => 'ASC',
+        );
+        $query = new WP_Query( $args );
+        $pages = $query->get_posts();
+
+        if ( empty( $pages ) ) {
+                return null;
+        }
+
+        return get_post( $pages[0], $output );
 }