Make WordPress Core


Ignore:
Timestamp:
09/20/2022 01:37:59 AM (19 months ago)
Author:
SergeyBiryukov
Message:

Date/Time: Minor tweak to support deprecated timezones on General Settings screen.

Underneath the timezone selector on the General Settings screen, a small snippet of info about the selected time zone is displayed.

This information would be missing if the timezone is set to a deprecated timezone value, even though PHP is perfectly capable of generating that information, including for deprecated timezones.

By passing the DateTimeZone::ALL_WITH_BC constant as the $timezoneGroup parameter to the PHP native timezone_identifiers_list() function, a timezone name list is retrieved containing both current and deprecated timezone names, preventing the condition from failing when the current timezone is a deprecated one.

See the extensive write-up about this in ticket #56468.

Also see: PHP Manual: timezone_identifiers_list().

Note: As this is an admin/output page, no pre-existing tests are available.

Follow-up to [54207], [54217], [54227], [54229], [54230], [54232], [54233].

Props jrf, costdev, marcyoast.
See #56468.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/options-general.php

    r53815 r54237  
    286286    <br />
    287287    <?php
    288     if ( in_array( $tzstring, timezone_identifiers_list(), true ) ) {
     288    if ( in_array( $tzstring, timezone_identifiers_list( DateTimeZone::ALL_WITH_BC ), true ) ) {
    289289        $transitions = timezone_transitions_get( timezone_open( $tzstring ), time() );
    290290
Note: See TracChangeset for help on using the changeset viewer.