Changeset 54240 for trunk/src/wp-includes/class-wpdb.php

Timestamp:

09/20/2022 02:49:25 AM (2 years ago)

Author:

desrosj

Message:

Networks and Sites: Officially remove global terms.

Global terms was a feature from the WordPress MU days where multisite and single site installs used different code bases.

In WordPress 3.0, WordPress MU was merged into one location and the UI [14854] and “on” switch [14880] for global terms were completely removed.

Even before this merge, global terms was bug infested and unreliable. After [14854]/[14880], the feature was no longer maintained and became increasingly broken as taxonomies progressed without it (term splitting and term meta do not work at all). At this point, the feature has not worked in 12+ years and there’s no hope for saving it.

This deprecates the remaining global terms related code and no-ops the functions.

Global terms, you don’t have to go home, but you can’t stay here.

Props scribu, wonderboymusic, SergeyBiryukov, nacin, pento, desrosj, johnjamesjacoby, johnbillion, dd32.
Fixes #21734.

File:

• trunk/src/wp-includes/class-wpdb.php (modified) (4 diffs)

trunk/src/wp-includes/class-wpdb.php

@@ -341 +341 @@
         'site',
         'sitemeta',
-        'sitecategories',
         'registration_log',
     );
+
+    /**
+     * List of deprecated WordPress Multisite global tables.
+     *
+     * @since 6.1.0
+     *
+     * @see wpdb::tables()
+     * @var string[]
+     */
+    public $old_ms_global_tables = array( 'sitecategories' );
 
     /**
@@ -1124 +1133 @@
      *
      * @since 3.0.0
+     * @since 6.1.0 `old` now includes deprecated multisite global tables only on multisite.
      *
      * @uses wpdb::$tables
@@ -1129 +1139 @@
      * @uses wpdb::$global_tables
      * @uses wpdb::$ms_global_tables
+     * @uses wpdb::$old_ms_global_tables
      *
      * @param string $scope   Optional. Possible values include 'all', 'global', 'ms_global', 'blog',
@@ -1160 +1171 @@
             case 'old':
                 $tables = $this->old_tables;
+                if ( is_multisite() ) {
+                    $tables = array_merge( $tables, $this->old_ms_global_tables );
+                }
                 break;
             default: