Changeset 54244

Timestamp:

09/20/2022 04:29:11 AM (2 years ago)

Author:

peterwilsoncc

Message:

Posts, Post types: Prevent get_sample_permalink() modifying the post object.

get_sample_permalink() (ab)uses the $post->filter property to indicate a sample permalink is being generated for the post. This change ensures the property is restored to its original value.

Props herregroen, hellofromTonya, peterwilsoncc, Rahmohn, costdev.
Fixes #54736.

Location:

trunk

Files:

• src/wp-admin/includes/post.php (modified) (2 diffs)
• tests/phpunit/tests/admin/includesPost.php (modified) (1 diff)

trunk/src/wp-admin/includes/post.php

@@ -1400 +1400 @@
     $original_date   = $post->post_date;
     $original_name   = $post->post_name;
+    $original_filter = $post->filter;
 
     // Hack: get_permalink() would return plain permalink for drafts, so we will fake that our post is published.
@@ -1444 +1445 @@
     $post->post_date   = $original_date;
     $post->post_name   = $original_name;
-    unset( $post->filter );
+    $post->filter      = $original_filter;
 
     /**

trunk/tests/phpunit/tests/admin/includesPost.php

@@ -685 +685 @@
         $this->assertSame( home_url() . '/parent-page/%pagename%/', $actual[0] );
         $this->assertSame( 'child-page', $actual[1] );
+    }
+
+    /**
+     * Tests that get_sample_permalink() preserves the original WP_Post properties.
+     *
+     * @ticket 54736
+     *
+     * @covers ::get_sample_permalink
+     */
+    public function test_get_sample_permalink_should_preserve_the_original_post_properties() {
+        $post = self::factory()->post->create_and_get(
+            array(
+                'post_status' => 'draft',
+            )
+        );
+
+        $post_original = clone $post;
+
+        add_filter(
+            'get_sample_permalink',
+            function( $permalink, $post_id, $title, $name, $post ) use ( $post_original ) {
+                $this->assertEquals( $post_original, $post, 'Modified post object passed to get_sample_permalink filter.' );
+                return $permalink;
+            },
+            10,
+            5
+        );
+
+        get_sample_permalink( $post );
+        $this->assertEquals( $post_original, $post, 'get_sample_permalink() modifies the post object.' );
     }