Changeset 54255

Timestamp:

09/20/2022 02:20:57 PM (2 years ago)

Author:

audrasjb

Message:

Media: Add caching to wp_count_attachments().

This changeset adds caching to wp_count_attachments(), for better consistency with wp_count_posts().

Props jeherve, antpb, mukesh27, robinwpdeveloper, costdev.
Fixes #55227.

Location:

trunk

Files:

• src/wp-includes/post.php (modified) (1 diff)
• tests/phpunit/tests/post/wpCountAttachments.php (added)

trunk/src/wp-includes/post.php

@@ -3091 +3091 @@
     global $wpdb;
 
-    $and   = wp_post_mime_type_where( $mime_type );
-    $count = $wpdb->get_results( "SELECT post_mime_type, COUNT( * ) AS num_posts FROM $wpdb->posts WHERE post_type = 'attachment' AND post_status != 'trash' $and GROUP BY post_mime_type", ARRAY_A );
-
-    $counts = array();
-    foreach ( (array) $count as $row ) {
-        $counts[ $row['post_mime_type'] ] = $row['num_posts'];
-    }
-    $counts['trash'] = $wpdb->get_var( "SELECT COUNT( * ) FROM $wpdb->posts WHERE post_type = 'attachment' AND post_status = 'trash' $and" );
+    $cache_key = sprintf(
+        'attachments%s',
+        ! empty( $mime_type ) ? ':' . str_replace( '/', '_', implode( '-', (array) $mime_type ) ) : ''
+    );
+
+    $counts = wp_cache_get( $cache_key, 'counts' );
+    if ( false == $counts ) {
+        $and   = wp_post_mime_type_where( $mime_type );
+        $count = $wpdb->get_results( "SELECT post_mime_type, COUNT( * ) AS num_posts FROM $wpdb->posts WHERE post_type = 'attachment' AND post_status != 'trash' $and GROUP BY post_mime_type", ARRAY_A );
+
+        $counts = array();
+        foreach ( (array) $count as $row ) {
+            $counts[ $row['post_mime_type'] ] = $row['num_posts'];
+        }
+        $counts['trash'] = $wpdb->get_var( "SELECT COUNT( * ) FROM $wpdb->posts WHERE post_type = 'attachment' AND post_status = 'trash' $and" );
+
+        wp_cache_set( $cache_key, (object) $counts, 'counts' );
+    }
 
     /**