Changeset 54291

Timestamp:

09/23/2022 01:58:19 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Block Editor: Remove repetitive calls to file_get_contents() in block editor settings.

The get_default_block_editor_settings() function used to repeatedly get the default-editor-styles.css file contents without any implementation to avoid this.

This commit utilizes a static variable to remove repetitive calls made during the same request. In tests ran on the front page of a site using Xdebug & Webgrind, the total file_get_contents() invocation count goes down from 181 to 93, and total self cost (the time that the function is responsible for) goes down from 160 ms to 93 ms.

Follow-up to [52042].

Props aristath, mukesh27.
Fixes #56637.

File:

• trunk/src/wp-includes/block-editor.php (modified) (1 diff)

trunk/src/wp-includes/block-editor.php

@@ -193 +193 @@
         // themes without their own editor styles.
         $default_editor_styles_file = ABSPATH . WPINC . '/css/dist/block-editor/default-editor-styles.css';
-        if ( file_exists( $default_editor_styles_file ) ) {
+
+        static $default_editor_styles_file_contents = false;
+        if ( ! $default_editor_styles_file_contents && file_exists( $default_editor_styles_file ) ) {
+                $default_editor_styles_file_contents = file_get_contents( $default_editor_styles_file );
+        }
+
+        $default_editor_styles = array();
+        if ( $default_editor_styles_file_contents ) {
                 $default_editor_styles = array(
-                        array( 'css' => file_get_contents( $default_editor_styles_file ) ),
+                        array( 'css' => $default_editor_styles_file_contents ),
                 );
-        } else {
-                $default_editor_styles = array();
         }