Changeset 54345 for trunk/src/wp-includes/option.php

Timestamp:

09/28/2022 01:42:12 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Options, Meta APIs: Prevent excessive notoptions key lookups.

When the notoptions key does not exist in a persistent object cache, it was requested hundreds of times until the first not-option is written.

This commit improves performance by setting the value to an empty array to prevent non-existent notoptions key from triggering multiple key lookups.

Follow-up to [4855], [14515].

Props tillkruess, dd32, spacedmonkey.
Fixes #56639.

File:

• trunk/src/wp-includes/option.php (modified) (1 diff)

trunk/src/wp-includes/option.php

@@ -164 +164 @@
         // Prevent non-existent options from triggering multiple queries.
         $notoptions = wp_cache_get( 'notoptions', 'options' );
+
+        // Prevent non-existent `notoptions` key from triggering multiple key lookups.
+        if ( ! is_array( $notoptions ) ) {
+            $notoptions = array();
+            wp_cache_set( 'notoptions', $notoptions, 'options' );
+        }
 
         if ( isset( $notoptions[ $option ] ) ) {