Make WordPress Core


Ignore:
Timestamp:
09/28/2022 10:17:38 PM (17 months ago)
Author:
SergeyBiryukov
Message:

I18N: Use correct default value for JavaScript translations path.

The $path parameter of some script translation functions had a default value of null, even though the parameter is documented as a string.

This commit corrects the default value for $path in:

  • WP_Dependency::set_translations()
  • WP_Scripts::set_translations()
  • wp_set_script_translations()

Additionally, this commit removes an is_string() check for $path in load_script_textdomain(). Now that the default value for $path in that function has also been corrected to an empty string instead of null, that check is no longer necessary, as it would hide an error which should be fixed (at the source of the problem) instead.

Follow-up to [54349].

Props jrf, johnjamesjacoby.
See #55967, #55656.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/l10n.php

    r54349 r54351  
    10661066    }
    10671067
    1068     if ( is_string( $path ) ) {
    1069         $path = untrailingslashit( $path );
    1070     }
    1071 
     1068    $path   = untrailingslashit( $path );
    10721069    $locale = determine_locale();
    10731070
Note: See TracChangeset for help on using the changeset viewer.