Changeset 54377

Timestamp:

10/04/2022 03:31:04 AM (2 years ago)

Author:

peterwilsoncc

Message:

Posts, Post types: Prevent get_page_by_title() parsing query twice.

In get_page_by_title() access the populated WP_Query::posts property directly rather than via the WP_Query::get_posts() method. This removes unnecessary reprocessing of the query.

Follow up to [54234].

Props david.binda, mukesh27, spacedmonkey.
Fixes #56721.

Location:

trunk

Files:

• src/wp-includes/post.php (modified) (1 diff)
• tests/phpunit/tests/post/getPageByTitle.php (modified) (1 diff)

trunk/src/wp-includes/post.php

@@ -5788 +5788 @@
     );
     $query = new WP_Query( $args );
-    $pages = $query->get_posts();
+    $pages = $query->posts;
 
     if ( empty( $pages ) ) {

trunk/tests/phpunit/tests/post/getPageByTitle.php

@@ -316 +316 @@
         $this->assertSame( $num_queries, get_num_queries(), 'Should not result in another database query.' );
     }
+
+    /**
+     * Ensure get_page_by_title() only runs the query once.
+     *
+     * @ticket 56721
+     * @covers ::get_page_by_title
+     */
+    public function test_should_not_run_query_more_than_once() {
+        $page = self::factory()->post->create_and_get(
+            array(
+                'post_title' => 'some-page',
+                'post_type'  => 'page',
+            )
+        );
+
+        // Use the `pre_get_posts` hook to ensure the query is only run once.
+        $ma = new MockAction();
+        add_action( 'pre_get_posts', array( $ma, 'action' ) );
+
+        get_page_by_title( 'some-page' );
+        $this->assertSame( 1, $ma->get_call_count(), 'Query does not run exactly once.' );
+    }
 }