Changeset 54402 for trunk/tests/phpunit/tests/functions.php

Timestamp:

10/07/2022 01:02:07 AM (2 years ago)

Author:

desrosj

Message:

Tests: Replace some occurrences of assertEquals() with assertSame().

This ensures that not only the return values match the expected results, but also that their type is the same.

Props costdev, desrosj.
See #55654.

File:

• trunk/tests/phpunit/tests/functions.php (modified) (6 diffs)

trunk/tests/phpunit/tests/functions.php

@@ -2057 +2057 @@
      */
     public function test_wp_get_default_extension_for_mime_type() {
-        $this->assertEquals( 'jpg', wp_get_default_extension_for_mime_type( 'image/jpeg' ), 'jpg not returned as default extension for "image/jpeg"' );
+        $this->assertSame( 'jpg', wp_get_default_extension_for_mime_type( 'image/jpeg' ), 'jpg not returned as default extension for "image/jpeg"' );
         $this->assertNotEquals( 'jpeg', wp_get_default_extension_for_mime_type( 'image/jpeg' ), 'jpeg should not be returned as default extension for "image/jpeg"' );
-        $this->assertEquals( 'png', wp_get_default_extension_for_mime_type( 'image/png' ), 'png not returned as default extension for "image/png"' );
+        $this->assertSame( 'png', wp_get_default_extension_for_mime_type( 'image/png' ), 'png not returned as default extension for "image/png"' );
         $this->assertFalse( wp_get_default_extension_for_mime_type( 'wibble/wobble' ), 'false not returned for unrecognized mime type' );
         $this->assertFalse( wp_get_default_extension_for_mime_type( '' ), 'false not returned when empty string as mime type supplied' );
@@ -2073 +2073 @@
     function test_wp_filesize_with_nonexistent_file() {
         $file = 'nonexistent/file.jpg';
-        $this->assertEquals( 0, wp_filesize( $file ) );
+        $this->assertSame( 0, wp_filesize( $file ) );
     }
 
@@ -2083 +2083 @@
         $file = DIR_TESTDATA . '/images/test-image-upside-down.jpg';
 
-        $this->assertEquals( filesize( $file ), wp_filesize( $file ) );
+        $this->assertSame( filesize( $file ), wp_filesize( $file ) );
 
         $filter = function() {
@@ -2091 +2091 @@
         add_filter( 'wp_filesize', $filter );
 
-        $this->assertEquals( 999, wp_filesize( $file ) );
+        $this->assertSame( 999, wp_filesize( $file ) );
 
         $pre_filter = function() {
@@ -2099 +2099 @@
         add_filter( 'pre_wp_filesize', $pre_filter );
 
-        $this->assertEquals( 111, wp_filesize( $file ) );
+        $this->assertSame( 111, wp_filesize( $file ) );
     }
 
@@ -2185 +2185 @@
             'version'  => 1,
         );
-        $this->assertEquals( $theme_json, $expected_theme_json );
+        $this->assertSameSetsWithIndex( $theme_json, $expected_theme_json );
     }