Changeset 54402 for trunk/tests/phpunit/tests/user/query.php

Timestamp:

10/07/2022 01:02:07 AM (4 years ago)

Author:

desrosj

Message:

Tests: Replace some occurrences of assertEquals() with assertSame().

This ensures that not only the return values match the expected results, but also that their type is the same.

Props costdev, desrosj.
See #55654.

File:

• trunk/tests/phpunit/tests/user/query.php (modified) (3 diffs)

trunk/tests/phpunit/tests/user/query.php

@@ -53 +53 @@
                 $users = new WP_User_Query();
 
-                $this->assertEquals( '', $users->get( 'fields' ) );
+                $this->assertNull( $users->get( 'fields' ) );
                 if ( isset( $users->query_vars['fields'] ) ) {
                         $this->assertSame( '', $users->query_vars['fields'] );
@@ -583 +583 @@
                 $query->prepare_query( array( 'fields' => 'all' ) );
                 $this->assertEmpty( $query->query_limit );
-                $this->assertEquals( '', $query->query_limit );
+                $this->assertNull( $query->query_limit );
                 $_query_vars = $query->query_vars;
 
@@ -1686 +1686 @@
 
                 // Must include user that has the same string in display_name.
-                $this->assertEquals( array( $new_user1 ), $ids );
+                $this->assertSameSetsWithIndex( array( (string) $new_user1 ), $ids );
         }