Changeset 54414

Timestamp:

10/07/2022 02:23:58 PM (2 years ago)

Author:

davidbaumwald

Message:

Administration: Guard against undefined $GLOBALS['hook_suffix'] in WP_Screen::get().

When initially defaulting the screen $id in WP_Screen::get(), if the $hook_name parameter is not supplied, an else fallback uses $GLOBALS['hook_suffix']. However, in some cases, hook_suffix doesn't exist in the global scope. This produces an "Undefined index" notice on < PHP 8, and a warning in >= PHP 8.

This change ensures $GLOBALS['hook_suffix'] has a value before using it as a fallback for the screen ID.

Props splendorstudio, SergeyBiryukov, htdat, mukesh27, dd32, costdev.
Fixes #49089.

File:

• trunk/src/wp-admin/includes/class-wp-screen.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-screen.php

@@ -213 +213 @@
         }
 
+        $id              = '';
         $post_type       = null;
         $taxonomy        = null;
@@ -221 +222 @@
         if ( $hook_name ) {
             $id = $hook_name;
-        } else {
+        } elseif ( ! empty( $GLOBALS['hook_suffix'] ) ) {
             $id = $GLOBALS['hook_suffix'];
         }