Changeset 54425

Timestamp:

10/09/2022 04:26:57 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Tests: Clean up test images in WP_Customize_Manager tests.

The test for WP_Customizer_Manager::import_theme_starter_content() creates two attachments that remain in the uploads directory after the test run is complete.

This commit follows the approach from WP_REST_Posts_Controller tests and utilizes an $attachments_created property to track any files uploaded in the current test run and clean them up afterwards.

This makes sure there are no leftover images after the test class is run.

Follow-up to [39276], [39346], [39411], [40142], [53935], [54424].

See #55652.

File:

• trunk/tests/phpunit/tests/customize/manager.php (modified) (3 diffs)

trunk/tests/phpunit/tests/customize/manager.php

@@ -35 +35 @@
 
     /**
+     * Whether any attachments have been created in the current test run.
+     *
+     * @var bool
+     */
+    private $attachments_created = false;
+
+    /**
      * Set up before class.
      *
@@ -57 +64 @@
      */
     public function tear_down() {
+        if ( true === $this->attachments_created ) {
+            $this->remove_added_uploads();
+            $this->attachments_created = false;
+        }
+
         $this->manager = null;
         unset( $GLOBALS['wp_customize'] );
@@ -545 +557 @@
             )
         );
+
+        $this->attachments_created = true;
+
         $existing_published_home_page_id   = self::factory()->post->create(
             array(