Changeset 54445

Timestamp:

10/10/2022 03:15:31 PM (4 years ago)

Author:

davidbaumwald

Message:

Editor: Dynamic site editor template names performance improvements.

This change updates get_(posts|terms)() to direct WP_Query calls and adds additional parameters to each query to improve performance.

Follow-up to [54280], [54333], [54370], and [54388].

Props spacedmonkey, peterwilsoncc.
See #56467.

File:

• trunk/src/wp-includes/block-template-utils.php (modified) (4 diffs)

trunk/src/wp-includes/block-template-utils.php

@@ -547 +547 @@
         $post_type_object = get_post_type_object( $post_type );
 
-        $posts = get_posts(
-                array(
-                        'name'      => $slug,
-                        'post_type' => $post_type,
-                )
-        );
+        $default_args = array(
+                'post_type'              => $post_type,
+                'post_status'            => 'publish',
+                'posts_per_page'         => 1,
+                'update_post_meta_cache' => false,
+                'update_post_term_cache' => false,
+                'ignore_sticky_posts'    => true,
+                'no_found_rows'          => true,
+        );
+
+        $args  = array(
+                'name' => $slug,
+        );
+        $args  = wp_parse_args( $args, $default_args );
+        $posts = new WP_Query( $args );
 
         if ( empty( $posts ) ) {
@@ -580 +589 @@
         );
 
-        $posts_with_same_title = get_posts(
-                array(
-                        'title'       => $post_title,
-                        'post_type'   => $post_type,
-                        'post_status' => 'publish',
-                )
-        );
+        $args = array(
+                'title' => $post_title,
+        );
+        $args = wp_parse_args( $args, $default_args );
+
+        $posts_with_same_title = new WP_Query( $args );
 
         if ( count( $posts_with_same_title ) > 1 ) {
@@ -616 +624 @@
         $taxonomy_object = get_taxonomy( $taxonomy );
 
-        $terms = get_terms(
-                array(
-                        'taxonomy'   => $taxonomy,
-                        'hide_empty' => false,
-                        'slug'       => $slug,
-                )
-        );
+        $default_args = array(
+                'taxonomy'               => $taxonomy,
+                'hide_empty'             => false,
+                'update_term_meta_cache' => false,
+        );
+
+        $term_query = new WP_Term_Query();
+
+        $args  = array(
+                'number' => 1,
+                'slug'   => $slug,
+        );
+        $args  = wp_parse_args( $args, $default_args );
+        $terms = $term_query->query( $args );
 
         if ( empty( $terms ) ) {
@@ -649 +664 @@
         );
 
-        $terms_with_same_title = get_terms(
-                array(
-                        'taxonomy'   => $taxonomy,
-                        'hide_empty' => false,
-                        'name'       => $term_title,
-                )
-        );
+        $term_query = new WP_Term_Query();
+
+        $args = array(
+                'number' => 2,
+                'name'   => $term_title,
+        );
+        $args = wp_parse_args( $args, $default_args );
+
+        $terms_with_same_title = $term_query->query( $args );
 
         if ( count( $terms_with_same_title ) > 1 ) {