Changeset 54469 for trunk/src/wp-admin/includes/update.php

Timestamp:

10/11/2022 08:46:00 AM (2 years ago)

Author:

audrasjb

Message:

I18N: Use wp.i18n._n() for plural forms in wp_print_admin_notice_templates().

This changeset adds better support for plural forms in update admin notices generated on the Themes and Plugins screens. This fixes issues when translating into languages that have more than one plural form, or more complicated rules for singular form usage.

Props ideag, SergeyBiryukov, daledupreez, audrasjb.
Fixes #37287.

File:

• trunk/src/wp-admin/includes/update.php (modified) (1 diff)

trunk/src/wp-admin/includes/update.php

@@ -886 +886 @@
             <p>
                 <# if ( data.successes ) { #>
-                    <# if ( 1 === data.successes ) { #>
-                        <# if ( 'plugin' === data.type ) { #>
-                            <?php
-                            /* translators: %s: Number of plugins. */
-                            printf( __( '%s plugin successfully updated.' ), '{{ data.successes }}' );
-                            ?>
-                        <# } else { #>
-                            <?php
-                            /* translators: %s: Number of themes. */
-                            printf( __( '%s theme successfully updated.' ), '{{ data.successes }}' );
-                            ?>
-                        <# } #>
+                    <# if ( 'plugin' === data.type ) { #>
+                        {{ wp.i18n.sprintf( wp.i18n._n( '%s plugin successfully updated.', '%s plugins successfully updated.', data.successes ), data.successes ) }}
                     <# } else { #>
-                        <# if ( 'plugin' === data.type ) { #>
-                            <?php
-                            /* translators: %s: Number of plugins. */
-                            printf( __( '%s plugins successfully updated.' ), '{{ data.successes }}' );
-                            ?>
-                        <# } else { #>
-                            <?php
-                            /* translators: %s: Number of themes. */
-                            printf( __( '%s themes successfully updated.' ), '{{ data.successes }}' );
-                            ?>
-                        <# } #>
+                        {{ wp.i18n.sprintf( wp.i18n._n( '%s theme successfully updated.', '%s themes successfully updated.', data.successes ), data.successes ) }}
                     <# } #>
                 <# } #>
                 <# if ( data.errors ) { #>
                     <button class="button-link bulk-action-errors-collapsed" aria-expanded="false">
-                        <# if ( 1 === data.errors ) { #>
-                            <?php
-                            /* translators: %s: Number of failed updates. */
-                            printf( __( '%s update failed.' ), '{{ data.errors }}' );
-                            ?>
-                        <# } else { #>
-                            <?php
-                            /* translators: %s: Number of failed updates. */
-                            printf( __( '%s updates failed.' ), '{{ data.errors }}' );
-                            ?>
-                        <# } #>
+                        {{ wp.i18n.sprintf( wp.i18n._n( '%s update failed.', '%s updates failed.' , data.errors ), data.errors ) }}
                         <span class="screen-reader-text"><?php _e( 'Show more details' ); ?></span>
                         <span class="toggle-indicator" aria-hidden="true"></span>