Changeset 54481

Timestamp:

10/11/2022 02:58:03 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Add AllowDynamicProperties attribute to recently introduced classes.

This commit is a follow-up to [54133] for new classes introduced in WordPress 6.1 since the previous commit.

Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.

There are a number of ways to mitigate this:

• If it is an accidental typo for a declared property: fix the typo.
• For known properties: declare them on the class.
• For unknown properties: add the magic __get(), __set(), et al. methods to the class or let the class extend stdClass which has highly optimized versions of these magic methods built in.
• For unknown use of dynamic properties, the #[AllowDynamicProperties] attribute can be added to the class. The attribute will automatically be inherited by child classes.

Trac ticket #56034 is open to investigate and handle the third and fourth type of situations, however it has become clear this will need more time and will not be ready in time for WP 6.1.

To reduce “noise” in the meantime, both in the error logs of WP users moving onto PHP 8.2, in the test run logs of WP itself, in test runs of plugins and themes, as well as to prevent duplicate tickets from being opened for the same issue, the #[AllowDynamicProperties] attribute has been added to all “parent” classes in WP.

Reference: ​PHP RFC: Deprecate dynamic properties.

Follow-up to [53922], [54133].

Props jrf.
See #56513, #56034.

Location:

trunk/src/wp-includes

Files:

• class-wp-theme-json-data.php (modified) (1 diff)
• style-engine/class-wp-style-engine-css-declarations.php (modified) (1 diff)
• style-engine/class-wp-style-engine-css-rule.php (modified) (1 diff)
• style-engine/class-wp-style-engine-css-rules-store.php (modified) (1 diff)
• style-engine/class-wp-style-engine-processor.php (modified) (1 diff)
• style-engine/class-wp-style-engine.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-theme-json-data.php

@@ -11 +11 @@
  * Class to provide access to update a theme.json structure.
  */
+#[AllowDynamicProperties]
 class WP_Theme_JSON_Data {
 

trunk/src/wp-includes/style-engine/class-wp-style-engine-css-declarations.php

@@ -17 +17 @@
  * @since 6.1.0
  */
+#[AllowDynamicProperties]
 class WP_Style_Engine_CSS_Declarations {
 

trunk/src/wp-includes/style-engine/class-wp-style-engine-css-rule.php

@@ -17 +17 @@
  * @since 6.1.0
  */
+#[AllowDynamicProperties]
 class WP_Style_Engine_CSS_Rule {
 

trunk/src/wp-includes/style-engine/class-wp-style-engine-css-rules-store.php

@@ -17 +17 @@
  * @since 6.1.0
  */
+#[AllowDynamicProperties]
 class WP_Style_Engine_CSS_Rules_Store {
 

trunk/src/wp-includes/style-engine/class-wp-style-engine-processor.php

@@ -17 +17 @@
  * @since 6.1.0
  */
+#[AllowDynamicProperties]
 class WP_Style_Engine_Processor {
 

trunk/src/wp-includes/style-engine/class-wp-style-engine.php

@@ -22 +22 @@
  * @since 6.1.0
  */
+#[AllowDynamicProperties]
 final class WP_Style_Engine {
     /**