Make WordPress Core


Ignore:
Timestamp:
10/14/2022 05:58:20 AM (18 months ago)
Author:
peterwilsoncc
Message:

Tests: Replace the timezone used in date/time tests.

The Europe/Kiev timezone has been deprecated in PHP 8.2 and replaced with Europe/Kyiv.

The tests updated in this commit are testing the WordPress date/time functionality. They are not testing whether WP or PHP can handle deprecated timezone names correctly.

To ensure the tests follow the original purpose, the use of Europe/Kiev within these tests is now replaced with the Europe/Helsinki timezone, which is within the same timezone as Europe/Kyiv. This should ensure that these tests run without issue and test what they are supposed to be testing on every supported PHP version (unless at some point in the future Europe/Helsinki would be renamed, but that's a bridge to cross if and when).

Note: Separate tests should/will be added to ensure that relevant date/time related functions handle a deprecated timezone correctly, but that is not something these tests are supposed to be testing.

Follow-up to [45853], [45856], [45876], [45882], [45887], [45908], [45914], [46577], [46154], [46580], [46864], [46974], [54207].

Props jrf, costdev, SergeyBiryukov.
Merges [54217] to the 6.0 branch.
See #56468.

Location:
branches/6.0
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • branches/6.0

  • branches/6.0/tests/phpunit/tests/date/dateI18n.php

    r50291 r54512  
    1212     */
    1313    public function test_should_return_current_time_on_invalid_timestamp() {
    14         $timezone = 'Europe/Kiev';
     14        $timezone = 'Europe/Helsinki';
    1515        update_option( 'timezone_string', $timezone );
    1616
     
    2525     */
    2626    public function test_should_handle_zero_timestamp() {
    27         $timezone = 'Europe/Kiev';
     27        $timezone = 'Europe/Helsinki';
    2828        update_option( 'timezone_string', $timezone );
    2929
     
    144144     */
    145145    public function test_should_return_wp_timestamp() {
    146         update_option( 'timezone_string', 'Europe/Kiev' );
     146        update_option( 'timezone_string', 'Europe/Helsinki' );
    147147
    148148        $datetime     = new DateTimeImmutable( 'now', wp_timezone() );
     
    194194    public function dst_times() {
    195195        return array(
    196             'Before DST start' => array( '2019-03-31 02:59:00', 'Europe/Kiev' ),
    197             'After DST start'  => array( '2019-03-31 04:01:00', 'Europe/Kiev' ),
    198             'Before DST end'   => array( '2019-10-27 02:59:00', 'Europe/Kiev' ),
    199             'After DST end'    => array( '2019-10-27 04:01:00', 'Europe/Kiev' ),
     196            'Before DST start' => array( '2019-03-31 02:59:00', 'Europe/Helsinki' ),
     197            'After DST start'  => array( '2019-03-31 04:01:00', 'Europe/Helsinki' ),
     198            'Before DST end'   => array( '2019-10-27 02:59:00', 'Europe/Helsinki' ),
     199            'After DST end'    => array( '2019-10-27 04:01:00', 'Europe/Helsinki' ),
    200200        );
    201201    }
Note: See TracChangeset for help on using the changeset viewer.