Changeset 54514 for branches/5.8/tests/phpunit/tests/date/mysql2date.php

Timestamp:

10/14/2022 06:56:01 AM (3 years ago)

Author:

peterwilsoncc

Message:

Tests: Replace the timezone used in date/time tests.

The Europe/Kiev timezone has been deprecated in PHP 8.2 and replaced with Europe/Kyiv.

The tests updated in this commit are testing the WordPress date/time functionality. They are not testing whether WP or PHP can handle deprecated timezone names correctly.

To ensure the tests follow the original purpose, the use of Europe/Kiev within these tests is now replaced with the Europe/Helsinki timezone, which is within the same timezone as Europe/Kyiv. This should ensure that these tests run without issue and test what they are supposed to be testing on every supported PHP version (unless at some point in the future Europe/Helsinki would be renamed, but that's a bridge to cross if and when).

Note: Separate tests should/will be added to ensure that relevant date/time related functions handle a deprecated timezone correctly, but that is not something these tests are supposed to be testing.

Follow-up to [45853], [45856], [45876], [45882], [45887], [45908], [45914], [46577], [46154], [46580], [46864], [46974], [54207].

Props jrf, costdev, SergeyBiryukov.
Merges [54217] to the 5.8 branch.
See #56468.

Location:

branches/5.8

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/date/mysql2date.php (modified) (4 diffs)

branches/5.8/tests/phpunit/tests/date/mysql2date.php

@@ -34 +34 @@
      */
     function test_mysql2date_should_format_time() {
-        $timezone = 'Europe/Kiev';
+        $timezone = 'Europe/Helsinki';
         update_option( 'timezone_string', $timezone );
         $datetime = new DateTime( 'now', new DateTimeZone( $timezone ) );
@@ -48 +48 @@
      */
     function test_mysql2date_should_format_time_with_changed_time_zone() {
-        $timezone = 'Europe/Kiev';
+        $timezone = 'Europe/Helsinki';
         // phpcs:ignore WordPress.DateTime.RestrictedFunctions.timezone_change_date_default_timezone_set
         date_default_timezone_set( $timezone );
@@ -63 +63 @@
      * @ticket 28992
      */
-    function test_mysql2date_should_return_wp_timestamp() {
-        $timezone = 'Europe/Kiev';
+    public function test_mysql2date_should_return_wp_timestamp() {
+        $timezone = 'Europe/Helsinki';
         update_option( 'timezone_string', $timezone );
         $datetime     = new DateTime( 'now', new DateTimeZone( $timezone ) );
@@ -77 +77 @@
      * @ticket 28992
      */
-    function test_mysql2date_should_return_unix_timestamp_for_gmt_time() {
-        $timezone = 'Europe/Kiev';
+    public function test_mysql2date_should_return_unix_timestamp_for_gmt_time() {
+        $timezone = 'Europe/Helsinki';
         update_option( 'timezone_string', $timezone );
         $datetime  = new DateTime( 'now', new DateTimeZone( 'UTC' ) );