Changeset 54548 for branches/5.8/src/wp-includes/widgets.php

Timestamp:

10/17/2022 05:46:39 PM (2 years ago)

Author:

audrasjb

Message:

Grouped backports to the 5.8 branch.

• Editor: Bump @wordpress packages for the 5.9 branch,
• Media: Refactor search by filename within the admin,
• REST API: Lockdown post parameter of the terms endpoint,
• Customize: Escape blogname option in underscores templates,
• Query: Validate relation in WP_Date_Query,
• Users: Revert use of shared objects for current user,
• Posts, Post types: Apply KSES to post-by-email content,
• General: Validate host on "Are you sure?" screen,
• Posts, Post types: Remove emails from post-by-email logs,
• Pings/trackbacks: Apply KSES to all trackbacks,
• Mail: Reset PHPMailer properties between use,
• Comments: Apply kses when editing comments,
• Widgets: Escape RSS error messages for display.

Merges [54521-54530] to the 5.8 branch.
Props audrasjb, costdev, cu121, dd32, davidbaumwald, ehtis, johnbillion, johnjamesjacoby, martinkrcho, matveb, oztaser, paulkevan, peterwilsoncc, ravipatel, SergeyBiryukov, talldanwp, timothyblynjacobs, tykoted, voldemortensen, vortfu, xknown.

Location:

branches/5.8

Files:

• . (modified) (1 prop)
• src/wp-includes/widgets.php (modified) (2 diffs)

branches/5.8/src/wp-includes/widgets.php

@@ -1535 +1535 @@
     if ( is_wp_error( $rss ) ) {
         if ( is_admin() || current_user_can( 'manage_options' ) ) {
-            echo '<p><strong>' . __( 'RSS Error:' ) . '</strong> ' . $rss->get_error_message() . '</p>';
+            echo '<p><strong>' . __( 'RSS Error:' ) . '</strong> ' . esc_html( $rss->get_error_message() ) . '</p>';
         }
         return;
@@ -1658 +1658 @@
 
     if ( ! empty( $args['error'] ) ) {
-        echo '<p class="widget-error"><strong>' . __( 'RSS Error:' ) . '</strong> ' . $args['error'] . '</p>';
+        echo '<p class="widget-error"><strong>' . __( 'RSS Error:' ) . '</strong> ' . esc_html( $args['error'] ) . '</p>';
     }