Changeset 54568 for branches/4.8/src/wp-includes/class-wp-query.php

Timestamp:

10/17/2022 06:10:19 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Grouped backports to the 4.8 branch.

• Posts, Post types: Apply KSES to post-by-email content,
• General: Validate host on "Are you sure?" screen,
• Posts, Post types: Remove emails from post-by-email logs,
• Media: Refactor search by filename within the admin,
• Pings/trackbacks: Apply KSES to all trackbacks,
• Comments: Apply kses when editing comments,
• Customize: Escape blogname option in underscores templates,
• REST API: Lockdown post parameter of the terms endpoint,
• Mail: Reset PHPMailer properties between use,
• Query: Validate relation in WP_Date_Query,
• Widgets: Escape RSS error messages for display.

Merges [54521], [54522], [54523], [54524], [54525], [54526], [54527], [54528], [54529], [54530], [54541] to the 4.8 branch.
Props voldemortensen, johnbillion, paulkevan, peterwilsoncc, xknown, dd32, audrasjb, martinkrcho, vortfu, davidbaumwald, tykoted, timothyblynjacobs, johnjamesjacoby, ehtis, matveb, talldanwp.

Location:

branches/4.8

Files:

• . (modified) (1 prop)
• src/wp-includes/class-wp-query.php (modified) (5 diffs)

branches/4.8/src/wp-includes/class-wp-query.php

@@ -487 +487 @@
         private $compat_methods = array( 'init_query_flags', 'parse_tax_query' );
 
+        /**
+         * Controls whether an attachment query should include filenames or not.
+         *
+         * @since 6.0.3
+         * @var bool
+         */
+        protected $allow_query_attachment_by_filename = false;
         /**
          * Resets query flags to false.
@@ -1347 +1354 @@
 
                         $like = $n . $wpdb->esc_like( $term ) . $n;
-                        $search .= $wpdb->prepare( "{$searchand}(({$wpdb->posts}.post_title $like_op %s) $andor_op ({$wpdb->posts}.post_excerpt $like_op %s) $andor_op ({$wpdb->posts}.post_content $like_op %s))", $like, $like, $like );
+
+                        if ( ! empty( $this->allow_query_attachment_by_filename ) ) {
+                                $search .= $wpdb->prepare( "{$searchand}(({$wpdb->posts}.post_title $like_op %s) $andor_op ({$wpdb->posts}.post_excerpt $like_op %s) $andor_op ({$wpdb->posts}.post_content $like_op %s) $andor_op (sq1.meta_value $like_op %s))", $like, $like, $like, $like );
+                        } else {
+                                $search .= $wpdb->prepare( "{$searchand}(({$wpdb->posts}.post_title $like_op %s) $andor_op ({$wpdb->posts}.post_excerpt $like_op %s) $andor_op ({$wpdb->posts}.post_content $like_op %s))", $like, $like, $like );
+                        }
                         $searchand = ' AND ';
                 }
@@ -1684 +1696 @@
                 $q = $this->fill_query_vars($q);
 
+                /**
+                 * Filters whether an attachment query should include filenames or not.
+                 *
+                 * @since 6.0.3
+                 *
+                 * @param bool $allow_query_attachment_by_filename Whether or not to include filenames.
+                 */
+                $this->allow_query_attachment_by_filename = apply_filters( 'wp_allow_query_attachment_by_filename', false );
+                remove_all_filters( 'wp_allow_query_attachment_by_filename' );
+
                 // Parse meta query
                 $this->meta_query = new WP_Meta_Query();
@@ -2088 +2110 @@
                 }
 
-                if ( !empty( $this->tax_query->queries ) || !empty( $this->meta_query->queries ) ) {
+                if ( ! empty( $this->tax_query->queries ) || ! empty( $this->meta_query->queries ) || ! empty( $this->allow_query_attachment_by_filename ) ) {
                         $groupby = "{$wpdb->posts}.ID";
                 }
@@ -2136 +2158 @@
                 }
                 $where .= $search . $whichauthor . $whichmimetype;
+
+                if ( ! empty( $this->allow_query_attachment_by_filename ) ) {
+                        $join .= " LEFT JOIN {$wpdb->postmeta} AS sq1 ON ( {$wpdb->posts}.ID = sq1.post_id AND sq1.meta_key = '_wp_attached_file' )";
+                }
 
                 if ( ! empty( $this->meta_query->queries ) ) {