Changeset 54568 for branches/4.8/src/wp-includes/widgets.php

Timestamp:

10/17/2022 06:10:19 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Grouped backports to the 4.8 branch.

• Posts, Post types: Apply KSES to post-by-email content,
• General: Validate host on "Are you sure?" screen,
• Posts, Post types: Remove emails from post-by-email logs,
• Media: Refactor search by filename within the admin,
• Pings/trackbacks: Apply KSES to all trackbacks,
• Comments: Apply kses when editing comments,
• Customize: Escape blogname option in underscores templates,
• REST API: Lockdown post parameter of the terms endpoint,
• Mail: Reset PHPMailer properties between use,
• Query: Validate relation in WP_Date_Query,
• Widgets: Escape RSS error messages for display.

Merges [54521], [54522], [54523], [54524], [54525], [54526], [54527], [54528], [54529], [54530], [54541] to the 4.8 branch.
Props voldemortensen, johnbillion, paulkevan, peterwilsoncc, xknown, dd32, audrasjb, martinkrcho, vortfu, davidbaumwald, tykoted, timothyblynjacobs, johnjamesjacoby, ehtis, matveb, talldanwp.

Location:

branches/4.8

Files:

• . (modified) (1 prop)
• src/wp-includes/widgets.php (modified) (2 diffs)

branches/4.8/src/wp-includes/widgets.php

@@ -1234 +1234 @@
         if ( is_wp_error($rss) ) {
                 if ( is_admin() || current_user_can('manage_options') )
-                        echo '<p><strong>' . __( 'RSS Error:' ) . '</strong> ' . $rss->get_error_message() . '</p>';
+                        echo '<p><strong>' . __( 'RSS Error:' ) . '</strong> ' . esc_html( $rss->get_error_message() ) . '</p>';
                 return;
         }
@@ -1343 +1343 @@
 
         if ( ! empty( $args['error'] ) ) {
-                echo '<p class="widget-error"><strong>' . __( 'RSS Error:' ) . '</strong> ' . $args['error'] . '</p>';
+                echo '<p class="widget-error"><strong>' . __( 'RSS Error:' ) . '</strong> ' . esc_html( $args['error'] ) . '</p>';
         }