Changeset 54568 for branches/4.8/tests/phpunit/tests/query/search.php

Timestamp:

10/17/2022 06:10:19 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Grouped backports to the 4.8 branch.

• Posts, Post types: Apply KSES to post-by-email content,
• General: Validate host on "Are you sure?" screen,
• Posts, Post types: Remove emails from post-by-email logs,
• Media: Refactor search by filename within the admin,
• Pings/trackbacks: Apply KSES to all trackbacks,
• Comments: Apply kses when editing comments,
• Customize: Escape blogname option in underscores templates,
• REST API: Lockdown post parameter of the terms endpoint,
• Mail: Reset PHPMailer properties between use,
• Query: Validate relation in WP_Date_Query,
• Widgets: Escape RSS error messages for display.

Merges [54521], [54522], [54523], [54524], [54525], [54526], [54527], [54528], [54529], [54530], [54541] to the 4.8 branch.
Props voldemortensen, johnbillion, paulkevan, peterwilsoncc, xknown, dd32, audrasjb, martinkrcho, vortfu, davidbaumwald, tykoted, timothyblynjacobs, johnjamesjacoby, ehtis, matveb, talldanwp.

Location:

branches/4.8

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/query/search.php (modified) (5 diffs)

branches/4.8/tests/phpunit/tests/query/search.php

@@ -371 +371 @@
 
         add_post_meta( $attachment, '_wp_attached_file', 'some-image1.png', true );
-        add_filter( 'posts_clauses', '_filter_query_attachment_filenames' );
+        add_filter( 'wp_allow_query_attachment_by_filename', '__return_true' );
 
         // Pass post_type a string value.
@@ -397 +397 @@
 
         add_post_meta( $attachment, '_wp_attached_file', 'some-image2.png', true );
-        add_filter( 'posts_clauses', '_filter_query_attachment_filenames' );
+        add_filter( 'wp_allow_query_attachment_by_filename', '__return_true' );
 
         // Pass post_type an array value.
@@ -448 +448 @@
         add_post_meta( $attachment, '_wp_attached_file', 'some-image4.png', true );
         add_post_meta( $attachment, '_test_meta_key', 'value', true );
-        add_filter( 'posts_clauses', '_filter_query_attachment_filenames' );
+        add_filter( 'wp_allow_query_attachment_by_filename', '__return_true' );
 
         // Pass post_type a string value.
@@ -484 +484 @@
 
         add_post_meta( $attachment, '_wp_attached_file', 'some-image5.png', true );
-        add_filter( 'posts_clauses', '_filter_query_attachment_filenames' );
+        add_filter( 'wp_allow_query_attachment_by_filename', '__return_true' );
 
         // Pass post_type a string value.
@@ -507 +507 @@
      * @ticket 22744
      */
-    public function test_filter_query_attachment_filenames_unhooks_itself() {
-        add_filter( 'posts_clauses', '_filter_query_attachment_filenames' );
-
-        apply_filters( 'posts_clauses', array(
-            'where'    => '',
-            'groupby'  => '',
-            'join'     => '',
-            'orderby'  => '',
-            'distinct' => '',
-            'fields'   => '',
-            'limit'    => '',
-        ) );
-
-        $result = has_filter( 'posts_clauses', '_filter_query_attachment_filenames' );
-
-        $this->assertFalse( $result );
+    public function test_wp_query_removes_filter_wp_allow_query_attachment_by_filename() {
+        $attachment = self::factory()->post->create(
+            array(
+                'post_type'    => 'attachment',
+                'post_status'  => 'publish',
+                'post_title'   => 'bar foo',
+                'post_content' => 'foo bar',
+                'post_excerpt' => 'This post has foo',
+            )
+        );
+
+        add_post_meta( $attachment, '_wp_attached_file', 'some-image1.png', true );
+        add_filter( 'wp_allow_query_attachment_by_filename', '__return_true' );
+
+        $q = new WP_Query(
+            array(
+                's'           => 'image1',
+                'fields'      => 'ids',
+                'post_type'   => 'attachment',
+                'post_status' => 'inherit',
+            )
+        );
+
+        $this->assertSame( array( $attachment ), $q->posts );
+
+        /*
+         * WP_Query should have removed the wp_allow_query_attachment_by_filename filter
+         * and thus not match the attachment created above
+         */
+        $q->get_posts();
+        $this->assertEmpty( $q->posts );
     }