Changeset 54634 for trunk/src/wp-includes/class-wp-query.php

Timestamp:

10/18/2022 03:06:48 PM (3 years ago)

Author:

spacedmonkey

Message:

Query: Remove placeholder from query cache key.

Remove escape placeholder from query cache key, as placeholders are a based on a unique id on every request. This means that it is impossible for a cache to be reused, making queries that use escape placeholders such as LIKE searches, unable to be cached.

Props dhl, spacedmonkey, peterwilsoncc, desrosj, chaion07, davidbaumwald, mukesh27.
Fixes #56802.

File:

• trunk/src/wp-includes/class-wp-query.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-query.php

@@ -3116 +3116 @@
                 $cache_args['update_post_term_cache'],
                 $cache_args['lazy_load_term_meta'],
-                $cache_args['update_menu_item_cache']
+                $cache_args['update_menu_item_cache'],
+                $cache_args['search_orderby_title']
             );
 
             $new_request = str_replace( $fields, "{$wpdb->posts}.*", $this->request );
+            $new_request = $wpdb->remove_placeholder_escape( $new_request );
             $key         = md5( serialize( $cache_args ) . $new_request );
 
@@ -3127 +3129 @@
             }
 
-            $cache_key   = "wp_query:$key:$last_changed";
+            $cache_key = "wp_query:$key:$last_changed";
+
+            /**
+             * Filters query cache key.
+             *
+             * @since 6.1.0
+             *
+             * @param string   $cache_key   Cache key.
+             * @param array    $cache_args  Query args used to generate the cache key.
+             * @param string   $new_request SQL Query.
+             * @param WP_Query $query       The WP_Query instance.
+             */
+            $cache_key = apply_filters( 'wp_query_cache_key', $cache_key, $cache_args, $new_request, $this );
+
             $cache_found = false;
             if ( null === $this->posts ) {