Changeset 54650

Timestamp:

10/19/2022 06:18:45 PM (2 years ago)

Author:

desrosj

Message:

General: Correctly refer to “npm” and “Node.js”.

This update all references to npm and Node.js to their correct spelling.

Fixes #56816.

Location:

trunk

Files:

• .github/workflows/coding-standards.yml (modified) (3 diffs)
• .github/workflows/end-to-end-tests.yml (modified) (2 diffs)
• .github/workflows/javascript-tests.yml (modified) (3 diffs)
• .github/workflows/phpunit-tests.yml (modified) (2 diffs)
• .github/workflows/test-coverage.yml (modified) (2 diffs)
• .github/workflows/test-npm.yml (modified) (9 diffs)
• README.md (modified) (1 diff)
• SECURITY.md (modified) (1 diff)
• src/index.php (modified) (1 diff)
• src/js/_enqueues/vendor/README.md (modified) (2 diffs)

trunk/.github/workflows/coding-standards.yml

@@ -22 +22 @@
       - '**.js'
       - '**.php'
-      # These files configure NPM. Changes could affect the outcome.
+      # These files configure npm. Changes could affect the outcome.
       - 'package*.json'
       # These files configure Composer. Changes could affect the outcome.
@@ -126 +126 @@
   # - Checks out the repository.
   # - Logs debug information about the GitHub Action runner.
-  # - Installs NodeJS.
+  # - Installs Node.js.
   # - Logs updated debug information.
-  # _ Installs NPM dependencies.
+  # _ Installs npm dependencies.
   # - Run the WordPress JSHint checks.
   # - Ensures version-controlled files are not modified or deleted.
@@ -150 +150 @@
           svn --version
 
-      - name: Install NodeJS
+      - name: Install Node.js
         uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # v3.5.1
         with:

trunk/.github/workflows/end-to-end-tests.yml

@@ -37 +37 @@
   # - Checks out the repository.
   # - Logs debug information about the GitHub Action runner.
-  # - Installs NodeJS.
-  # _ Installs NPM dependencies.
+  # - Installs Node.js.
+  # _ Installs npm dependencies.
   # - Builds WordPress to run from the `build` directory.
   # - Starts the WordPress Docker container.
@@ -73 +73 @@
           locale -a
 
-      - name: Install NodeJS
+      - name: Install Node.js
         uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # v3.5.1
         with:

trunk/.github/workflows/javascript-tests.yml

@@ -20 +20 @@
       # Any change to a JavaScript file should run tests.
       - '**.js'
-      # These files configure NPM. Changes could affect the outcome.
+      # These files configure npm. Changes could affect the outcome.
       - 'package*.json'
       # This file configures ESLint. Changes could affect the outcome.
@@ -45 +45 @@
   # - Checks out the repository.
   # - Logs debug information about the GitHub Action runner.
-  # - Installs NodeJS.
+  # - Installs Node.js.
   # - Logs updated debug information.
-  # _ Installs NPM dependencies.
+  # _ Installs npm dependencies.
   # - Run the WordPress QUnit tests.
   # - Ensures version-controlled files are not modified or deleted.
@@ -67 +67 @@
           svn --version
 
-      - name: Install NodeJS
+      - name: Install Node.js
         uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # v3.5.1
         with:

trunk/.github/workflows/phpunit-tests.yml

@@ -38 +38 @@
   # - Sets environment variables.
   # - Sets up the environment variables needed for testing with memcached (if desired).
-  # - Installs NodeJS.
-  # - Installs NPM dependencies
+  # - Installs Node.js.
+  # - Installs npm dependencies
   # - Configures caching for Composer.
   # - Installs Composer dependencies.
@@ -109 +109 @@
         uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # v3.1.0
 
-      - name: Install NodeJS
+      - name: Install Node.js
         uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # v3.5.1
         with:

trunk/.github/workflows/test-coverage.yml

@@ -40 +40 @@
   # - Checks out the WordPress Importer plugin (needed for the Core PHPUnit tests).
   # - Logs debug information about the GitHub Action runner.
-  # - Installs NodeJS.
-  # _ Installs NPM dependencies.
+  # - Installs Node.js.
+  # _ Installs npm dependencies.
   # - Logs Docker debug information (about the Docker installation within the runner).
   # - Starts the WordPress Docker container.
@@ -87 +87 @@
           locale -a
 
-      - name: Install NodeJS
+      - name: Install Node.js
         uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # v3.5.1
         with:

trunk/.github/workflows/test-npm.yml

@@ -1 @@
-name: Test NPM
+name: Test npm
 
 on:
@@ -16 +16 @@
       - '[4-9].[0-9]'
     paths:
-      # These files configure NPM. Changes could affect the outcome.
+      # These files configure npm. Changes could affect the outcome.
       - 'package*.json'
-      # JavaScript files are built using NPM.
+      # JavaScript files are built using npm.
       - '**.js'
-      # CSS and SCSS files are built using NPM.
+      # CSS and SCSS files are built using npm.
       - '**.scss'
       - '**.css'
@@ -38 +38 @@
 
 jobs:
-  # Verifies that installing NPM dependencies and building WordPress works as expected.
+  # Verifies that installing npm dependencies and building WordPress works as expected.
   #
   # Performs the following steps:
   # - Checks out the repository.
   # - Logs debug information about the GitHub Action runner.
-  # - Installs NodeJS.
-  # _ Installs NPM dependencies.
+  # - Installs Node.js.
+  # _ Installs npm dependencies.
   # - Builds WordPress to run from the `build` directory.
   # - Cleans up after building WordPress to the `build` directory.
@@ -52 +52 @@
   # - Ensures version-controlled files are not modified or deleted.
   test-npm:
-    name: Test NPM on ${{ matrix.os }}
+    name: Test npm on ${{ matrix.os }}
     runs-on: ${{ matrix.os }}
     timeout-minutes: 20
@@ -73 +73 @@
           svn --version
 
-      - name: Install NodeJS
+      - name: Install Node.js
         uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # v3.5.1
         with:
@@ -100 +100 @@
         run: git diff --exit-code
 
-  # Verifies that installing NPM dependencies and building WordPress works as expected on MacOS.
+  # Verifies that installing npm dependencies and building WordPress works as expected on MacOS.
   #
   # This is separate from the job above in order to use stricter conditions about when to run.
@@ -108 +108 @@
   # - Checks out the repository.
   # - Logs debug information about the GitHub Action runner.
-  # - Installs NodeJS.
-  # _ Installs NPM dependencies.
+  # - Installs Node.js.
+  # _ Installs npm dependencies.
   # - Builds WordPress to run from the `build` directory.
   # - Cleans up after building WordPress to the `build` directory.
@@ -117 +117 @@
   # - Ensures version-controlled files are not modified or deleted.
   test-npm-macos:
-    name: Test NPM on MacOS
+    name: Test npm on MacOS
     runs-on: macos-latest
     timeout-minutes: 30
@@ -133 +133 @@
           svn --version
 
-      - name: Install NodeJS
+      - name: Install Node.js
         uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # v3.5.1
         with:

trunk/README.md

@@ -20 +20 @@
 If you are not using a package manager, see the [Node.js download page](https://nodejs.org/en/download/) for installers and binaries.
 
-**Note:** WordPress currently only supports NodeJS `14.x` and npm `6.x`.
+**Note:** WordPress currently only supports Node.js `14.x` and npm `6.x`.
 
 You will also need [Docker](https://www.docker.com/products/docker-desktop) installed and running on your computer. Docker is the virtualization software that powers the local development environment. Docker can be installed just like any other regular application.

trunk/SECURITY.md

@@ -77 +77 @@
 *   Any non-severe vulnerability on `irclogs.wordpress.org`, `lists.wordpress.org`, or any other low impact site.
 *   Clickjacking with minimal security implications
-*   Vulnerabilities in Composer/NPM `devDependencies`, unless there's a practical way to exploit it remotely.
+*   Vulnerabilities in Composer/npm `devDependencies`, unless there's a practical way to exploit it remotely.
 *   Theoretical vulnerabilities where you can't demonstrate a significant security impact with a PoC.
 

trunk/src/index.php

@@ -56 +56 @@
 
 $die .= '<p>' . sprintf(
-    /* translators: 1: NPM URL, 2: Handbook URL. */
-    __( 'This requires <a href="%1$s">NPM</a>. <a href="%2$s">Learn more about setting up your local development environment</a>.' ),
+    /* translators: 1: npm URL, 2: Handbook URL. */
+    __( 'This requires <a href="%1$s">npm</a>. <a href="%2$s">Learn more about setting up your local development environment</a>.' ),
     'https://www.npmjs.com/get-npm',
     __( 'https://make.wordpress.org/core/handbook/tutorials/installing-wordpress-locally/' )

trunk/src/js/_enqueues/vendor/README.md

@@ -1 +1 @@
 # src/js/enqueues/vendor
 
-In this directory you'll find vendor JavaScript packages that cannot be installed through NPM, but are included in WordPress. Below we've documented the sources for those packages.
+In this directory you'll find vendor JavaScript packages that cannot be installed through npm, but are included in WordPress. Below we've documented the sources for those packages.
 
 ## Folder dependencies
@@ -63 +63 @@
 - iris: https://github.com/Automattic/Iris
 - json2: https://github.com/douglascrockford/JSON-js
-- jquery/jquery.color: https://github.com/jquery/jquery-color. Package is on NPM but not published by maintainer.
+- jquery/jquery.color: https://github.com/jquery/jquery-color. Package is on npm but not published by maintainer.
 - jquery/jquery.hotkeys: https://github.com/tzuryby/jquery.hotkeys
-- jquery/jquery.masonry: Old version for BC purposes, can't include two versions with NPM. The newer version is included through NPM and built to `wp-includes/js/masonry.min.js`
+- jquery/jquery.masonry: Old version for BC purposes, can't include two versions with npm. The newer version is included through npm and built to `wp-includes/js/masonry.min.js`
 - jquery/jquery.query: https://github.com/blairmitchelmore/jquery.plugins/blob/master/jquery.query.js
 - jquery/jquery.schedule: https://github.com/rse/jquery-schedule