Changeset 54706 for trunk/src/wp-includes/class-wp-theme-json-resolver.php

Timestamp:

10/27/2022 04:32:42 PM (4 years ago)

Author:

davidbaumwald

Message:

Themes: Ensure custom global styles are imported properly.

This change removes caching of global styles for logged in users, allowing "wp_global_styles" custom post type to be imported completely, regardless of any previously cached data. This change now relies on the lower-level native WP_Query cache invalidation methods for the global styles post type.

Follow-up to [52275], [54186].

Props anariel-design, bernhard-reiter, andrewserong, spacedmonkey, andraganescu, peterwilsoncc, oandregal, hellofromTonya.
Fixes #56901.

File:

• trunk/src/wp-includes/class-wp-theme-json-resolver.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-theme-json-resolver.php

@@ -423 +423 @@
                         ),
                 );
-
-                $cache_key = sprintf( 'wp_global_styles_%s', md5( serialize( $args ) ) );
-                $post_id   = (int) get_transient( $cache_key );
-                // Special case: '-1' is a results not found.
-                if ( -1 === $post_id && ! $create_post ) {
-                        return $user_cpt;
-                }
-
-                if ( $post_id > 0 && in_array( get_post_status( $post_id ), (array) $post_status_filter, true ) ) {
-                        return get_post( $post_id, ARRAY_A );
-                }
 
                 $global_style_query = new WP_Query();
@@ -457 +446 @@
                         }
                 }
-                $cache_expiration = $user_cpt ? DAY_IN_SECONDS : HOUR_IN_SECONDS;
-                set_transient( $cache_key, $user_cpt ? $user_cpt['ID'] : -1, $cache_expiration );
 
                 return $user_cpt;