Changeset 54710 for trunk

Timestamp:

10/28/2022 02:08:20 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Move the tests for WP class methods to the wp directory.

This aims to bring some consistency to the location of the tests for this class.

Includes adding the missing @covers tags.

Follow-up to [36177], [51622], [54250].

Props pbearne, SergeyBiryukov.
See #56793, #56782.

Location:

trunk/tests/phpunit/tests/wp

Files:

• addQueryVar.php (copied) (copied from trunk/tests/phpunit/tests/wp.php ) (2 diffs)
• parseRequest.php (modified) (1 diff)
• removeQueryVar.php (moved) (moved from trunk/tests/phpunit/tests/wp.php ) (2 diffs)
• sendHeaders.php (modified) (1 diff)

trunk/tests/phpunit/tests/wp/addQueryVar.php

@@ -3 +3 @@
 /**
  * @group wp
+ *
+ * @covers WP::add_query_var
  */
-class Tests_WP extends WP_UnitTestCase {
+class Tests_WP_AddQueryVar extends WP_UnitTestCase {
+
         /**
          * @var WP
@@ -26 +29 @@
                 $this->assertContains( 'test2', $this->wp->public_query_vars );
         }
-
-        public function test_remove_query_var() {
-                $public_qv_count = count( $this->wp->public_query_vars );
-
-                $this->wp->add_query_var( 'test' );
-                $this->assertContains( 'test', $this->wp->public_query_vars );
-                $this->wp->remove_query_var( 'test' );
-
-                $this->assertCount( $public_qv_count, $this->wp->public_query_vars );
-        }
 }

trunk/tests/phpunit/tests/wp/parseRequest.php

@@ -3 +3 @@
 /**
  * @group wp
+ *
  * @covers WP::parse_request
  */
 class Tests_WP_ParseRequest extends WP_UnitTestCase {
+
         /**
          * @var WP

trunk/tests/phpunit/tests/wp/removeQueryVar.php

@@ -3 +3 @@
 /**
  * @group wp
+ *
+ * @covers WP::remove_query_var
  */
-class Tests_WP extends WP_UnitTestCase {
+class Tests_WP_RemoveQueryVar extends WP_UnitTestCase {
+
         /**
          * @var WP
@@ -13 +16 @@
                 parent::set_up();
                 $this->wp = new WP();
-        }
-
-        public function test_add_query_var() {
-                $public_qv_count = count( $this->wp->public_query_vars );
-
-                $this->wp->add_query_var( 'test' );
-                $this->wp->add_query_var( 'test2' );
-                $this->wp->add_query_var( 'test' );
-
-                $this->assertCount( $public_qv_count + 2, $this->wp->public_query_vars );
-                $this->assertContains( 'test', $this->wp->public_query_vars );
-                $this->assertContains( 'test2', $this->wp->public_query_vars );
         }
 

trunk/tests/phpunit/tests/wp/sendHeaders.php

@@ -3 +3 @@
 /**
  * @group wp
+ *
  * @covers WP::send_headers
  */