Changeset 54712 for trunk/src/wp-includes/post.php

Timestamp:

10/28/2022 03:16:29 PM (2 years ago)

Author:

antpb

Message:

Media: Reverts get_attached_file() changes for normalized Windows paths.

Based on feedback from network storage configurations there was a noticed slowdown due to the usage of the path_join() function. This needs more time to find a workaround.

Follow-up to [53934].
Props mreishus, SergeyBiryukov, desrosj, mikeschroder.
Reverts [53934].
See #56924.

File:

• trunk/src/wp-includes/post.php (modified) (1 diff)

trunk/src/wp-includes/post.php

@@ -725 +725 @@
 
     // If the file is relative, prepend upload dir.
-    if ( $file ) {
+    if ( $file && 0 !== strpos( $file, '/' ) && ! preg_match( '|^.:\\\|', $file ) ) {
         $uploads = wp_get_upload_dir();
-
         if ( false === $uploads['error'] ) {
-            $file = path_join( $uploads['basedir'], $file );
+            $file = $uploads['basedir'] . "/$file";
         }
     }