Changeset 54713 for branches/6.1/src/wp-includes/functions.php

Timestamp:

10/28/2022 03:28:59 PM (4 years ago)

Author:

antpb

Message:

Media: Reverts get_attached_file() changes for normalized Windows paths.

Based on feedback from network storage configurations there was a noticed slowdown due to the usage of the path_join() function. This needs more time to find a workaround.

Follow-up to [53934].
Props mreishus, SergeyBiryukov, desrosj, mikeschroder.
Reverts [53934] in the 6.1 Branch.
See #56924.

File:

• branches/6.1/src/wp-includes/functions.php (modified) (2 diffs)

branches/6.1/src/wp-includes/functions.php

@@ -2080 +2080 @@
  *
  * @since 2.5.0
- * @since 6.1.0 Allows normalized Windows paths (forward slashes).
  *
  * @param string $path File path.
@@ -2108 +2107 @@
         // Windows allows absolute paths like this.
         if ( preg_match( '#^[a-zA-Z]:\\\\#', $path ) ) {
-                return true;
-        }
-
-        // Normalized Windows paths for local filesystem and network shares (forward slashes).
-        if ( preg_match( '#(^[a-zA-Z]+:/|^//[\w!@\#\$%\^\(\)\-\'{}\.~]{1,15})#', $path ) ) {
                 return true;
         }