Make WordPress Core

Changeset 54719


Ignore:
Timestamp:
10/29/2022 03:42:26 PM (2 years ago)
Author:
SergeyBiryukov
Message:

Tests: Remove skipWithMultisite() and skipWithoutMultisite() from get_user_count() tests.

As the tests belong to either the ms-excluded or the ms-required group, the skipping should not be necessary.

While these methods were initially intended to be used in conjunction with the respective group, the PHPUnit configuration files for single site and multisite exclude these groups as appropriate, so calling these methods explicitly is no longer required.

Follow-up to [40520], [40543], [40564], [43005], [46683], [53011].

See #56793.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/user/getUserCount.php

    r53818 r54719  
    1212     */
    1313    public function test_wp_update_network_counts_on_different_network() {
    14         $this->skipWithoutMultisite();
    1514        $different_network_id = self::factory()->network->create(
    1615            array(
     
    3534     */
    3635    public function test_get_user_count_on_different_network() {
    37         $this->skipWithoutMultisite();
    3836        $different_network_id = self::factory()->network->create(
    3937            array(
     
    6159     */
    6260    public function test_enable_live_network_user_counts_filter() {
    63         $this->skipWithoutMultisite();
    6461        // False for large networks by default.
    6562        add_filter( 'enable_live_network_counts', '__return_false' );
     
    103100
    104101    /**
     102     * @ticket 38741
    105103     * @group ms-excluded
    106      * @ticket 38741
    107104     */
    108105    public function test_get_user_count_update_on_delete() {
    109         $this->skipWithMultisite();
    110106        wp_update_user_counts();
    111107        $current_network_user_count = get_user_count();
     
    125121
    126122    /**
     123     * @ticket 38741
    127124     * @group ms-required
    128      * @ticket 38741
    129125     */
    130126    public function test_get_user_count_update_on_delete_multisite() {
    131         $this->skipWithoutMultisite();
    132127        wp_update_user_counts();
    133128        $current_network_user_count = get_user_count();
     
    147142
    148143    /**
     144     * @ticket 38741
    149145     * @group multisite
    150146     * @group ms-required
    151      * @ticket 38741
    152147     */
    153148    public function test_get_user_count() {
    154         $this->skipWithoutMultisite();
    155149        // Refresh the cache.
    156150        wp_update_network_counts();
Note: See TracChangeset for help on using the changeset viewer.