Changeset 54751 for trunk

Timestamp:

11/04/2022 06:22:17 PM (4 years ago)

Author:

jorgefilipecosta

Message:

Fix: Category specific templates always appear as not found.

According to the docs in developer.wordpress.org/reference/classes/wp_term_query/query WP_Term_Query:->query( string|array $query ) returns WP_Term[]|int[]|string[]|string, and we were using an inexistent object property terms making it always empty and look like the taxonomy did not exist.

Props mamaduka, mikachan, ockham, franz00.
See #56902.

File:

• trunk/src/wp-includes/block-template-utils.php (modified) (3 diffs)

trunk/src/wp-includes/block-template-utils.php

@@ -638 +638 @@
         $terms_query = $term_query->query( $args );
 
-        if ( empty( $terms_query->terms ) ) {
+        if ( empty( $terms_query ) ) {
                 $template->title = sprintf(
                         /* translators: Custom template title in the Site Editor, referencing a taxonomy term that was not found. 1: Taxonomy singular name, 2: Term slug. */
@@ -648 +648 @@
         }
 
-        $term_title = $terms_query->terms[0]->name;
+        $term_title = $terms_query[0]->name;
 
         $template->title = sprintf(
@@ -672 +672 @@
         $terms_with_same_title_query = $term_query->query( $args );
 
-        if ( count( $terms_with_same_title_query->terms ) > 1 ) {
+        if ( count( $terms_with_same_title_query ) > 1 ) {
                 $template->title = sprintf(
                         /* translators: Custom template title in the Site Editor. 1: Template title, 2: Term slug. */