Changeset 54762 for trunk

Timestamp:

11/07/2022 08:53:18 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Restore blog switching in update_posts_count() test.

The previous iteration of the test passed when run in isolation but failed when running the whole test suite.

Restoring the switch_to_blog() call allows the test to pass again pending a deeper investigation.

Follow-up to [54760].

See #57023.

File:

• trunk/tests/phpunit/tests/multisite/updatePostsCount.php (modified) (3 diffs)

trunk/tests/phpunit/tests/multisite/updatePostsCount.php

@@ -22 +22 @@
                  */
                 public function test_update_posts_count() {
+                        $blog_id = self::factory()->blog->create();
+                        switch_to_blog( $blog_id );
+
                         $original_post_count = (int) get_site()->post_count;
 
                         $post_id = self::factory()->post->create();
+
+                        $post_count_after_creating = get_site()->post_count;
+
+                        wp_delete_post( $post_id );
+
+                        $post_count_after_deleting = get_site()->post_count;
+
+                        restore_current_blog();
 
                         /*
@@ -33 +44 @@
                          * which then calls update_posts_count() to update the count.
                          */
-                        $this->assertSame( $original_post_count + 1, get_site()->post_count, 'Post count should be incremented by 1.' );
-
-                        wp_delete_post( $post_id );
+                        $this->assertSame( $original_post_count + 1, $post_count_after_creating, 'Post count should be incremented by 1.' );
 
                         /*
@@ -44 +53 @@
                          * which then calls update_posts_count() to update the count.
                          */
-                        $this->assertSame( $original_post_count, get_site()->post_count, 'Post count should match the original count.' );
+                        $this->assertSame( $original_post_count, $post_count_after_deleting, 'Post count should match the original count.' );
                 }
         }