Changeset 54769 for trunk/src/wp-includes/block-editor.php

Timestamp:

11/09/2022 12:28:33 AM (3 years ago)

Author:

flixos90

Message:

Editor: Improve frontend performance for get_default_block_editor_settings().

The wp_max_upload_size() function can be expensive to call, especially for large sites or multisites. For the frontend usage of get_default_block_editor_settings() knowing the allowed upload size is typically unnecessary.

This changeset adds a condition so that wp_max_upload_size() is only called if the current user can actually upload_files. It keeps the data present when it is actually needed while avoiding the execution overhead when it is not needed.

Props janthiel, Clorith, flixos90, spacedmonkey.
Fixes #56815.

File:

• trunk/src/wp-includes/block-editor.php (modified) (1 diff)

trunk/src/wp-includes/block-editor.php

@@ -154 +154 @@
 function get_default_block_editor_settings() {
     // Media settings.
-    $max_upload_size = wp_max_upload_size();
-    if ( ! $max_upload_size ) {
-        $max_upload_size = 0;
+
+    // wp_max_upload_size() can be expensive, so only call it when relevant for the current user.
+    $max_upload_size = 0;
+    if ( current_user_can( 'upload_files' ) ) {
+        $max_upload_size = wp_max_upload_size();
+        if ( ! $max_upload_size ) {
+            $max_upload_size = 0;
+        }
     }